public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: 'Amit Kapila' <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Fix 035_standby_logical_decoding.pl race conditions
Date: Tue, 8 Apr 2025 15:27:41 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <Z/S/1sE64bbM4/[email protected]>
References: <OSCPR01MB1496631866E979BD510BC5448F5AF2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<Z+1RJElgG/[email protected]>
<CAA4eK1Krrie2X40qdj9Qu8D109DjjqS4nH-woJCheBtgdNyR_w@mail.gmail.com>
<OSCPR01MB14966608F78B5BFC907CF8E82F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAA4eK1Kd7Cxc=GBz58O_EX5xrQ5TzyNsHmqEtQNR9j=ox74u1w@mail.gmail.com>
<OSCPR01MB149666E4ECE1C38C60E496EDCF5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAA4eK1KBiW+wBFiNgPjm5VyKXCKUQ8igkmf4rnS98=P3RnAukg@mail.gmail.com>
<OSCPR01MB14966BE900F2F29594D5E1FE7F5B52@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<Z/S/1sE64bbM4/[email protected]>
On Tue, Apr 08, 2025 at 06:19:02AM +0000, Bertrand Drouvot wrote:
> - A new injection_points_wakeup_detach() function that is holding the spinlock
> during the whole duration to ensure that no process can wait in between the
> wakeup and the detach.
That would not a correct spinlock use. injection_points_detach() and
injection_points_wakeup_internal() do much more actions than what we
can internally do while holding a spinlock, including both
Postgres-specific calls as well as system calls. strcmp() and
strlcpy() are still OK-ish, even as system calls, as they work
directly on the strings given in input.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (63+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fix 035_standby_logical_decoding.pl race conditions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox