public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Amit Kapila <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Fix 035_standby_logical_decoding.pl race conditions
Date: Thu, 10 Apr 2025 12:00:20 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1+Eg-KwLX-UDY-1d0pFj45LiSaGrdrrDYv56YW+fStPLw@mail.gmail.com>
References: <OSCPR01MB149666E4ECE1C38C60E496EDCF5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAA4eK1KBiW+wBFiNgPjm5VyKXCKUQ8igkmf4rnS98=P3RnAukg@mail.gmail.com>
<OSCPR01MB14966BE900F2F29594D5E1FE7F5B52@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<Z/S/1sE64bbM4/[email protected]>
<[email protected]>
<Z/[email protected]>
<[email protected]>
<Z/YLrTO8/[email protected]>
<CAA4eK1+Eg-KwLX-UDY-1d0pFj45LiSaGrdrrDYv56YW+fStPLw@mail.gmail.com>
On Wed, Apr 09, 2025 at 12:07:31PM +0530, Amit Kapila wrote:
> On Wed, Apr 9, 2025 at 11:24 AM Bertrand Drouvot
> <[email protected]> wrote:
> I can't think of a good reason to have this DEBUG1 as there is no
> predictability of it getting generated even with tests using an
> injection point. OTOH, I don't have any objections to it if you would
> like to proceed with this.
The non-predictability of the event is my reason, as it can be useful
to know this information when grabbing for specific patterns in the
logs between failed and successful run differences. In short, I'd
like to think that we are OK here, still this information is free to
have and it could be useful if we still have problems. A custom
message WAL record is overdoing in it a bit, IMO, an elog() with the
LSN returned should be enough.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (55+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fix 035_standby_logical_decoding.pl race conditions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox