public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Thomas Munro <[email protected]>
Cc: Anton Voloshin <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: 039_end_of_wal: error in "xl_tot_len zero" test
Date: Thu, 15 Feb 2024 13:28:56 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKGL47fv64v6kXyz5t69yQdhp2KKFe4eR63Sk7Aitzxv=_A@mail.gmail.com>
References: <[email protected]>
<CA+hUKGL47fv64v6kXyz5t69yQdhp2KKFe4eR63Sk7Aitzxv=_A@mail.gmail.com>
On Fri, Jan 19, 2024 at 11:35:30AM +1300, Thomas Munro wrote:
> On Fri, Jan 19, 2024 at 1:47 AM Anton Voloshin
> <[email protected]> wrote:
>> I believe there is a small problem in the 039_end_of_wal.pl's
>> "xl_tot_len zero" test. It supposes that after immediate shutdown the
>> server, upon startup recovery, should always produce a message matching
>> "invalid record length at .*: wanted 24, got 0". However, if the
>> circumstances are just right and we happened to hit exactly on the edge
>> of WAL page, then the message on startup recovery would be "invalid
>> magic number 0000 in log segment .*, offset .*". The test does not take
>> that into account.
>
> Thanks for figuring this out! Right, I see. I will look more closely
> when I'm back from summer vacation in a few days, but first reaction:
Thomas, are you planning to look at that?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: 039_end_of_wal: error in "xl_tot_len zero" test
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox