pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Subject: Re: Injection points: some tools to wait and wake
Date: Tue, 27 Feb 2024 08:29:53 +0900
Message-ID: <Zd0e8SAwwA4U5UW_@paquier.xyz> (raw)
In-Reply-To: <19DE6301-C7C1-44C3-AB23-9574CD8C0579@yandex-team.ru>
References: <ZdNldOxVx4SL3+f0@ip-10-97-1-34.eu-west-3.compute.internal>
	<ZdPkHNMK8s4o0tV4@paquier.xyz>
	<ZdTLXCnN0EV0e/KF@ip-10-97-1-34.eu-west-3.compute.internal>
	<ZdUiw17n4Vy7aKMs@paquier.xyz>
	<ZdWqOHkYDfRe646C@paquier.xyz>
	<ZdXjfd+1JfTjASVg@ip-10-97-1-34.eu-west-3.compute.internal>
	<Zda5KYdMyrIqdPA5@paquier.xyz>
	<Zdb/GNeuheXi2ffg@ip-10-97-1-34.eu-west-3.compute.internal>
	<ZdwMFfl5j3SYC-Cx@paquier.xyz>
	<19DE6301-C7C1-44C3-AB23-9574CD8C0579@yandex-team.ru>

On Mon, Feb 26, 2024 at 02:10:49PM +0500, Andrey M. Borodin wrote:
> So that we could do something like
> 
> ok(node_standby->await_injection_point(“CreateRestartPoint”,”checkpointer"));

It would be more flexible with a full string to describe the test
rather than a process name in the second argument.

> IMO, this could make many tests cleaner.
> Or, perhaps, it’s a functionality for a future development?

This could just happen as separate refactoring, I guess.  But I'd wait
to see if more tests requiring scans to pg_stat_activity pop up.  For
example, the test just posted here does not rely on that:
https://www.postgresql.org/message-id/ZdyZya4YrNapWKqz@ip-10-97-1-34.eu-west-3.compute.internal
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (46+ messages)  latest in thread

Message-ID: <Zd0e8SAwwA4U5UW_@paquier.xyz>
Permalink:  ../Zd0e8SAwwA4U5UW_@paquier.xyz/
Also on:    postgresql.org/message-id/Zd0e8SAwwA4U5UW_@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, x4mmm@yandex-team.ru, bertranddrouvot.pg@gmail.com, pgsql-hackers@lists.postgresql.org, ashutosh.bapat.oss@gmail.com
  Subject: Re: Injection points: some tools to wait and wake
  In-Reply-To: <Zd0e8SAwwA4U5UW_@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox