public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Amul Sul <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Add system identifier to backup manifest
Date: Fri, 1 Mar 2024 14:58:37 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAJ_b97_9nJCD3kAmNfSnN1s7m9n1h97OP=APwts=g-rWGztxQ@mail.gmail.com>
References: <CAAJ_b9417seAdhwhMVr=PnQ+MPx7uAeS5FAw2qMCXF5MrE-7wQ@mail.gmail.com>
<CA+Tgmoa78r+U-X2EoGrvNDuKur5MhMtvZbm01-c1ziRgSq9MEA@mail.gmail.com>
<CAAJ_b97pp0=xXwW=VKWTxKDF2r7uYXYxZnTggF6dRHtnjwi+WA@mail.gmail.com>
<CA+Tgmoa8okr1YCFcCOGgvOTASiXsJgx-oqrCS41Wir=oC8c-mA@mail.gmail.com>
<CAAJ_b95tfUo9CyCX-=0V1L=VNzzvcf4dGLT6ae7=kz2ELy2Edg@mail.gmail.com>
<[email protected]>
<CAAJ_b961KftvFLJYvJ1-CWk13dLVcb0+o=q0BRd3n8NJ-ceWBQ@mail.gmail.com>
<CA+TgmoYrs8A2j-4KhkjtKp6MwJRwOkXHdXVg4DE6nDOMgDBxMA@mail.gmail.com>
<[email protected]>
<CAAJ_b97_9nJCD3kAmNfSnN1s7m9n1h97OP=APwts=g-rWGztxQ@mail.gmail.com>
On Mon, Feb 19, 2024 at 12:06:19PM +0530, Amul Sul wrote:
> Agreed, now they will have an error as _could not read file "<DataDir>": Is
> a directory_. But, IIUC, that what usually happens with the dev version, and
> the extension needs to be updated for compatibility with the newer version for
> the same reason.
I was reading through the remaining pieces of the patch set, and are
you sure that there is a need for 0002 at all? The only reason why
get_dir_controlfile() is introduced is to be able to get the contents
of a control file with a full path to it, and not a data folder. Now,
if I look closely, with 0002~0004 applied, the only two callers of
get_controlfile() are pg_combinebackup.c and pg_verifybackup.c. Both
of them have an access to the backup directories, which point to the
root of the data folder. pg_combinebackup can continue to use
backup_dirs[i]. pg_verifybackup has an access to the backup directory
in the context data, if I'm reading this right, so you could just use
that in verify_system_identifier().
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Add system identifier to backup manifest
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox