public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Drouvot, Bertrand <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Autogenerate some wait events code and documentation
Date: Tue, 19 Mar 2024 08:59:30 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <ZOxVHQwEC/9X/p/[email protected]>
<[email protected]>
On Mon, Mar 18, 2024 at 10:24:00AM +0100, Alvaro Herrera wrote:
> FTR I had a rather unpleasant time last week upon finding a wait event
> named PgSleep. If you grep for that, there are no matches at all; and I
> spent ten minutes (for real) trying to figure out where that was coming
> from, until I remembered this thread.
>
> Now you have to guess that not only random lowercasing is happening, but
> also underscore removal. This is not a good developer experience and I
> think we should rethink this choice. It would be infinitely more
> usable, and not one bit more difficult, to make these lines be
>
> WAIT_EVENT_FOO_BAR FooBar "Waiting on Foo Bar."
>
> then there is no guessing involved.
This has already gone through a couple of adjustments in 59cbf60c0f2b
and 183a60a628fe. The latter has led to the elimination of one column
in the txt file, as a reply to the same kind of comments about the
format of this file:
https://www.postgresql.org/message-id/20230705215939.ulnfbr4zavb2x7ri%40awork3.anarazel.de
FWIW, I still like better what we have currently, where it is possible
to grep the enum values in the source code.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (32+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Autogenerate some wait events code and documentation
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox