pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Subject: Re: Weird test mixup
Date: Tue, 9 Apr 2024 12:41:57 +0900
Message-ID: <ZhS5BV_FVDsRPSVV@paquier.xyz> (raw)
In-Reply-To: <B09D9D09-E8B6-411A-9DFD-45977DB5B75C@yandex-team.ru>
References: <e1a7ab78-1fa9-419c-b0d1-36d971bdf946@iki.fi>
	<ZfTcZW1-Kh3fFLnZ@paquier.xyz>
	<ZfeTLfltCTimaVbU@paquier.xyz>
	<Zg9frr5iIam3fhd7@paquier.xyz>
	<FB71B3B1-D68F-4508-BA95-D427792FAB2B@yandex-team.ru>
	<ZhNG4Io9uYOgwv3F@paquier.xyz>
	<ZhOd3NXAutteokGL@paquier.xyz>
	<D5877439-8DDF-4764-9A39-F0429B96005C@yandex-team.ru>
	<ZhOxGzDaZ81xVxzw@paquier.xyz>
	<B09D9D09-E8B6-411A-9DFD-45977DB5B75C@yandex-team.ru>

On Mon, Apr 08, 2024 at 12:29:43PM +0300, Andrey M. Borodin wrote:
> On 8 Apr 2024, at 11:55, Michael Paquier <michael@paquier.xyz> wrote:
>> Uh, I did not understand this. Because commit message was about
>> stabiilzizing tests, not extending coverage.

Okay, it is about stabilizing an existing test.

> Also, should we drop function wait_pid() at the end of a test?

Sure.

> Given that tweaks with are nothing new, I think patch looks good.

Applied that after a second check.  And thanks to Bharath for the
poke.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (52+ messages)  latest in thread

Message-ID: <ZhS5BV_FVDsRPSVV@paquier.xyz>
Permalink:  ../ZhS5BV_FVDsRPSVV@paquier.xyz/
Also on:    postgresql.org/message-id/ZhS5BV_FVDsRPSVV@paquier.xyz

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, x4mmm@yandex-team.ru, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, bharath.rupireddyforpostgres@gmail.com
  Subject: Re: Weird test mixup
  In-Reply-To: <ZhS5BV_FVDsRPSVV@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox