agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Imseih (AWS), Sami <simseih@amazon.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Date: Tue, 18 Jun 2024 14:00:00 -0500
Message-ID: <ZnHZMIJM6rgMVvvM@nathan> (raw)
In-Reply-To: <20240603232427.pjiyqggsr7duccr5@awork3.anarazel.de>
References: <96B4FC7B-A919-4F93-80A3-BA3EA4F8479A@amazon.com>
	<20240503010415.GA1008894@nathanxps13>
	<2780DB08-DCA6-4E57-B823-303A0E7E17D7@amazon.com>
	<20240507160605.GA2523153@nathanxps13>
	<011CA929-4933-40EA-B1D3-29131FEFBCF0@amazon.com>
	<20240517021646.GA1745636@nathanxps13>
	<Zl4Q7YGslvdL0eYj@nathan>
	<20240603190852.jcibstxflb33hjvu@awork3.anarazel.de>
	<Zl4ZTRdx38sDktRs@nathan>
	<20240603232427.pjiyqggsr7duccr5@awork3.anarazel.de>

On Mon, Jun 03, 2024 at 04:24:27PM -0700, Andres Freund wrote:
> On 2024-06-03 14:28:13 -0500, Nathan Bossart wrote:
>> On Mon, Jun 03, 2024 at 12:08:52PM -0700, Andres Freund wrote:
>> > Why do we think that increasing the number of PGPROC slots, heavyweight locks
>> > etc by 256 isn't going to cause issues?  That's not an insubstantial amount of
>> > memory to dedicate to something that will practically never be used.
>> 
>> I personally have not observed problems with these kinds of bumps in
>> resource usage, although I may be biased towards larger systems where it
>> doesn't matter as much.
> 
> IME it matters *more* on larger systems. Or at least used to, I haven't
> experimented with this in quite a while.
> 
> It's possible that we improved a bunch of things sufficiently for this to not
> matter anymore.

I'm curious if there is something specific you would look into to verify
this.  IIUC one concern is the lock table not fitting into L3.  Is there
anything else?  Any particular workloads you have in mind?

-- 
nathan





view thread (71+ messages)  latest in thread

Message-ID: <ZnHZMIJM6rgMVvvM@nathan>
Permalink:  ../ZnHZMIJM6rgMVvvM@nathan/
Also on:    postgresql.org/message-id/ZnHZMIJM6rgMVvvM@nathan

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, andres@anarazel.de, simseih@amazon.com, pryzby@telsasoft.com
  Subject: Re: allow changing autovacuum_max_workers without restarting
  In-Reply-To: <ZnHZMIJM6rgMVvvM@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox