pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal
Date: Wed, 10 Jul 2024 11:29:46 -0500
Message-ID: <Zo62-sTqbYJO3hHR@nathan> (raw)
In-Reply-To: <523cc094-0fe1-4e2c-9653-a3cf9cde0c49@oss.nttdata.com>
References: <6e30082e-041b-4e31-9633-95a66de76f5d@oss.nttdata.com>
	<ZoVgXuYWbzTLXyRY@nathan>
	<802ff3d5-fdc7-4b08-9046-2e9fc5fdae0e@oss.nttdata.com>
	<CA+TgmoYPNfgAT3OubjoYSiXTb3-urOjQxT3SCEUCrRBx5g6ihA@mail.gmail.com>
	<CA+TgmoY8DnzWNK_xu4=NTYdxGBGnFucrEpOALnS0awMp-s_pKQ@mail.gmail.com>
	<7c1b48d8-0f08-4733-a4e6-d55f04581db7@oss.nttdata.com>
	<CA+TgmoansG0B8ayQGw9Ozee6Jawz=HFUACpO_4gp-+SFJBxiYw@mail.gmail.com>
	<Zo6YPuvTmRW3b1s7@nathan>
	<523cc094-0fe1-4e2c-9653-a3cf9cde0c49@oss.nttdata.com>

On Thu, Jul 11, 2024 at 01:02:25AM +0900, Fujii Masao wrote:
> On 2024/07/10 23:18, Nathan Bossart wrote:
>> Yeah.  I initially thought this patch might be okay, at least as a stopgap,
>> but Jelte pointed out a case where it doesn't work, namely when you have
>> something like the following in the config file:
>> 
>> 	wal_level = 'minimal'
>> 	summarize_wal = 'true'
>> 	wal_level = 'logical'
> 
> Unless I'm mistaken, the patch works fine in this case. If the check_hook
> triggered every time a parameter appears in the configuration file,
> it would mistakenly detect wal_level=minimal and summarize_wal=on together
> and raise an error. However, this isn't the case. The check_hook is
> designed to trigger after duplicate parameters are deduplicated.
> Am I missing something?

After further research, I think you are right about that.

-- 
nathan





view thread (44+ messages)  latest in thread

Message-ID: <Zo62-sTqbYJO3hHR@nathan>
Permalink:  ../Zo62-sTqbYJO3hHR@nathan/
Also on:    postgresql.org/message-id/Zo62-sTqbYJO3hHR@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, masao.fujii@oss.nttdata.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal
  In-Reply-To: <Zo62-sTqbYJO3hHR@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox