pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal
Date: Tue, 16 Jul 2024 11:30:17 -0500
Message-ID: <ZpagGUyMkwg-LeKC@nathan> (raw)
In-Reply-To: <CA+TgmobLzdVQCjy9abec-UFrN1SmwHGv9WcaOD_XixmJN5e+=A@mail.gmail.com>
References: <CA+TgmoansG0B8ayQGw9Ozee6Jawz=HFUACpO_4gp-+SFJBxiYw@mail.gmail.com>
	<CA+TgmoZ53ADUm2UAGEspMuv-Db5SGtrOXUx=ps6LcGexsf5-fA@mail.gmail.com>
	<e2549085-5246-4edc-bc62-ae19df48acc5@oss.nttdata.com>
	<CA+TgmoYFOWbxk=FP+ZnxwVaKQEce=+0Xvzh0DUC9=YLNHiQW1w@mail.gmail.com>
	<8a668c51-c6af-4744-a978-c6a2ce3b1d83@oss.nttdata.com>
	<CA+TgmoYUhRa8j8_Jdrb9Ankz=c8NRLe_x1nf4L+Vc2V+DiTSWw@mail.gmail.com>
	<ZpVushkGx0_nYIip@nathan>
	<CA+TgmoaKqLrkjEg1j6NEHcMUj-Qk6yUK=qfFzy+G-w6OVVv+0Q@mail.gmail.com>
	<ZpWCJxL3tQm3lkLI@nathan>
	<CA+TgmobLzdVQCjy9abec-UFrN1SmwHGv9WcaOD_XixmJN5e+=A@mail.gmail.com>

On Tue, Jul 16, 2024 at 12:23:19PM -0400, Robert Haas wrote:
> TBH, I don't want to do that. I think it's too fragile. It's the sort
> of thing that just barely works given the exact behavior of these
> particular GUCs, but it relies on a bunch of subtle assumptions which
> won't be evident to future readers of the code. People will very
> possibly copy this barely-working code into other contexts where it
> doesn't work at all, or they'll think the code implementing this is
> buggy even if it isn't.

Agreed.  If there was really no other option, it would at the very least
need a humongous comment that explained why it worked in this specific case
and is unlikely to work in others.  But it sounds like we have another
choice... 

-- 
nathan





view thread (44+ messages)  latest in thread

Message-ID: <ZpagGUyMkwg-LeKC@nathan>
Permalink:  ../ZpagGUyMkwg-LeKC@nathan/
Also on:    postgresql.org/message-id/ZpagGUyMkwg-LeKC@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, robertmhaas@gmail.com, masao.fujii@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal
  In-Reply-To: <ZpagGUyMkwg-LeKC@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox