From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Euler Taveira <euler@eulerto.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: improve performance of pg_dump with many sequences
Date: Wed, 17 Jul 2024 14:05:03 -0500
Message-ID: <ZpgV32NTM0ADvJop@nathan> (raw)
In-Reply-To: <3578088.1721242766@sss.pgh.pa.us>
References: <Zo2LdwUamOq6HzIU@nathan>
<0a0f4d52-ab75-4d69-abe8-5713bf70eee6@app.fastmail.com>
<Zo8Fl53vBVS1Cnmt@nathan>
<d7f5942e-00ba-4d90-9bac-f0b2b7092dc4@app.fastmail.com>
<ZpCQTZtXL85P5SaT@nathan>
<Zpbnz4P13W7WICj-@nathan>
<ZpcsrAcClLt7AwdI@paquier.xyz>
<Zpc5HGb7yDfTNDy5@nathan>
<ZpgR4OMpbekeja_n@nathan>
<3578088.1721242766@sss.pgh.pa.us>
On Wed, Jul 17, 2024 at 02:59:26PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> On second thought, I worry that this change might needlessly complicate the
>> pg_sequences system view. Maybe we should just add a
>> pg_sequence_get_tuple() function that returns everything in
>> FormData_pg_sequence_data for a given sequence OID...
>
> Uh ... why do we need a function, rather than just
>
> select * from pg_sequence
We can use that for dumpSequence(), but dumpSequenceData() requires
information from the sequence tuple itself. Right now, we query each
sequence relation individually for that data, and I'm trying to find a way
to cut down on those round trips.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, euler@eulerto.com
Subject: Re: improve performance of pg_dump with many sequences
In-Reply-To: <ZpgV32NTM0ADvJop@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox