public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Subject: Re: query ID goes missing with extended query protocol
Date: Thu, 29 Aug 2024 07:48:07 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoZxtnf_jZ=VqBSyaU8hfUkkwoJCJ6ufy4LGpXaunKrjrg@mail.gmail.com>
References: <CA+TgmoZxtnf_jZ=VqBSyaU8hfUkkwoJCJ6ufy4LGpXaunKrjrg@mail.gmail.com>
On Wed, Aug 28, 2024 at 04:27:38PM -0400, Robert Haas wrote:
> - Add a call to
> pgstat_report_query_id(queryDesc->plannedstmt->queryId, false) to the
> top of ExecutorRun() with an appropriate comment.
> - Fix the incorrect comment mentioned above.
> - Back-patch to all releases containing 4f0b0966c86 i.e. v14+.
This is being discussed already on a different thread:
- Thread: https://www.postgresql.org/message-id/[email protected]...
- CF entry: https://commitfest.postgresql.org/49/4963/
There is a patch proposed there, that attempts to deal with the two
cases of a portal where ExecutorRun() is called once while holding a
tuplestore and where ExecutorRun() is called multiple times. A few
approaches have been discussed for the tests, where the new psql
metacommands added in d55322b0da60 should become handy. That's on my
TODO spreadsheet of things to look at, but I did not come back to it
yet.
A backpatch would be adapted for that, yep. I'd like to see tests on
HEAD at least.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: query ID goes missing with extended query protocol
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox