public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Partitioned tables and [un]loggedness
Date: Tue, 3 Sep 2024 09:22:58 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZtCKiJZaoYBHBv05@nathan>
References: <[email protected]>
	<20240424202640.GB861150@nathanxps13>
	<CAKFQuwY3RTTrp7x4OmEruMmOghdorhq4=eC0ZfG0NM+HnBWFsw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwZwMOkw-7112u1-gXEhRWuXiZe9otp801Z3dPVvarKdsA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<Zs4-xnNDMEdiKQXo@nathan>
	<[email protected]>
	<ZtCKiJZaoYBHBv05@nathan>

On Thu, Aug 29, 2024 at 09:49:44AM -0500, Nathan Bossart wrote:
> IMHO continuing to allow partitioned tables to be marked UNLOGGED just
> preserves the illusion that it does something.  An ERROR could help dispel
> that misconception.

Okay.  This is going to be disruptive if we do nothing about pg_dump,
unfortunately.  How about tweaking dumpTableSchema() so as we'd never
issue UNLOGGED for a partitioned table?  We could filter that out as
there is tbinfo->relkind.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Partitioned tables and [un]loggedness
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox