pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Ayush Vatsa <ayushvatsa1810@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch
Date: Thu, 12 Sep 2024 11:19:00 +0900
Message-ID: <ZuJPlHWN6HOO9AYD@paquier.xyz> (raw)
In-Reply-To: <CAEze2Wh_KkMthGmGiW+v9hFN90L066Vt3VQdEFmwmi03CgFRkA@mail.gmail.com>
References: <CA+TgmoYm0X=KuHry1A6prNzf3pUmAcXYgQEr25kCY8jSMJaVjg@mail.gmail.com>
	<ZszGBMK1D4hCsRnD@nathan>
	<CACX+KaNhg-ZwkqCSjsq7j_gRYDmHip2b4kwa6ohac0MspSeW9w@mail.gmail.com>
	<ZtCxo95K_bqGbmNQ@nathan>
	<CA+TgmoaHX9BYrr1u9c356ovGwVBy25Q9y_LdSYS8JW0pqd18JA@mail.gmail.com>
	<ZtI0O-bN90P02oQO@nathan>
	<CAEze2WiNB=wjrtQGERk2mmkpOZevGCfTT7ei6guJsFG4VRmacA@mail.gmail.com>
	<Ztd0VcV2PQJf5jUJ@nathan>
	<ZuH_PB1S3JuWvNPq@nathan>
	<CAEze2Wh_KkMthGmGiW+v9hFN90L066Vt3VQdEFmwmi03CgFRkA@mail.gmail.com>

On Wed, Sep 11, 2024 at 11:02:43PM +0100, Matthias van de Meent wrote:
> On Wed, 11 Sept 2024 at 21:36, Nathan Bossart <nathandbossart@gmail.com> wrote:
> >
> > Barring objections, I'm planning to commit v3 soon.  Robert/Matthias, I'm
> > not sure you are convinced this is the right thing to do (or worth doing,
> > rather), but I don't sense that you are actually opposed to it, either.
> > Please correct me if I am wrong.
> 
> Correct: I do think making heapam-related inspection functions have a
> consistent behaviour when applied to sequences is beneficial, with no
> preference towards specifically supporting or not supporting sequences
> in these functions. If people that work on sequences think it's better
> to also support inspection of sequences, then I think that's a good
> reason to add that support where it doesn't already exist.
> 
> As for patch v3, that seems fine with me.

+1 from here as well, after looking at what v3 is doing for these two
modules.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (29+ messages)  latest in thread

Message-ID: <ZuJPlHWN6HOO9AYD@paquier.xyz>
Permalink:  ../ZuJPlHWN6HOO9AYD@paquier.xyz/
Also on:    postgresql.org/message-id/ZuJPlHWN6HOO9AYD@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, boekewurm+postgres@gmail.com, nathandbossart@gmail.com, robertmhaas@gmail.com, ayushvatsa1810@gmail.com
  Subject: Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch
  In-Reply-To: <ZuJPlHWN6HOO9AYD@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox