public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: First draft of PG 17 release notes
Date: Fri, 13 Sep 2024 18:25:41 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Wed, Sep 11, 2024 at 07:50:40PM +0200, Álvaro Herrera wrote:
> Hello,
> 
> I noticed that these two items in the current notes are separate:
> 
> <!--
> Author: Alvaro Herrera <[email protected]>
> 2024-03-25 [374c7a229] Allow specifying an access method for partitioned tables
> Author: Alvaro Herrera <[email protected]>
> 2024-03-28 [e2395cdbe] ALTER TABLE: rework determination of access method ID
> -->
> 
>      <listitem>
>       <para>
>       Allow specification of partitioned <link linkend="tableam">table
>       access methods</link> (Justin Pryzby, Soumyadeep Chakraborty,
>       Michael Paquier)
>       </para>
>      </listitem>
> 
> <!--
> Author: Michael Paquier <[email protected]>
> 2024-03-08 [d61a6cad6] Add support for DEFAULT in ALTER TABLE .. SET ACCESS MET
> -->
> 
>      <listitem>
>       <para>
>       Add <literal>DEFAULT</literal> setting for <literal>ALTER TABLE
>       .. SET ACCESS METHOD</literal> (Michael Paquier)
>       </para>
>      </listitem>
> 
> They are very very closely related, so I suggest they should be
> together as a single item.  Also, the first one is somewhat strangely
> worded IMO (we don't have "partitioned table access methods" -- rather,
> we have table access methods for partitioned tables).  Maybe something
> like

Yes, agree, the wording needs improvement, patch attached.

> * Improve ALTER TABLE ... SET ACCESS METHOD
> 
>   This command can now also be applied to partitioned tables, so that it
>   can <link to "https://www.postgresql.org/docs/17/sql-altertable.html#SQL-ALTERTABLE-DESC-SET-ACCESS-METHOD";
>   influence partitions created later</link>. (Justin, Soumyadeep, Michaël)
> 
>   In addition, it now accepts the value DEFAULT to reset a previously
>   set value. (Michaël)

I moved the two items next to each other, but I am concerned combining
the partition feature with the DEFAULT features is just making it too
complicated to understand.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"


Attachments:

  [text/x-diff] REL_17_STABLE.diff (1.8K, ../[email protected]/2-REL_17_STABLE.diff)
  download | inline diff:
diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml
index 36e19bb8329..6d4ffa8ea1e 100644
--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -1659,23 +1659,6 @@ Author: Peter Eisentraut <[email protected]>
       </para>
      </listitem>
 
-<!--
-Author: Alvaro Herrera <[email protected]>
-2024-03-25 [374c7a229] Allow specifying an access method for partitioned tables
-Author: Alvaro Herrera <[email protected]>
-2024-03-28 [e2395cdbe] ALTER TABLE: rework determination of access method ID
--->
-
-     <listitem>
-      <para>
-      Allow specification of partitioned <link linkend="tableam">table
-      access methods</link> (Justin Pryzby, Soumyadeep Chakraborty,
-      Michael Paquier)
-      <ulink url="&commit_baseurl;374c7a229">&sect;</ulink>
-      <ulink url="&commit_baseurl;e2395cdbe">&sect;</ulink>
-      </para>
-     </listitem>
-
 <!--
 Author: Peter Eisentraut <[email protected]>
 2024-01-13 [4f622503d] Make attstattarget nullable
@@ -1714,6 +1697,23 @@ Author: Peter Eisentraut <[email protected]>
       </para>
      </listitem>
 
+<!--
+Author: Alvaro Herrera <[email protected]>
+2024-03-25 [374c7a229] Allow specifying an access method for partitioned tables
+Author: Alvaro Herrera <[email protected]>
+2024-03-28 [e2395cdbe] ALTER TABLE: rework determination of access method ID
+-->
+
+     <listitem>
+      <para>
+      Allow specification of <link linkend="tableam">table access
+      methods</link> on partitioned tables (Justin Pryzby, Soumyadeep
+      Chakraborty, Michael Paquier)
+      <ulink url="&commit_baseurl;374c7a229">&sect;</ulink>
+      <ulink url="&commit_baseurl;e2395cdbe">&sect;</ulink>
+      </para>
+     </listitem>
+
 <!--
 Author: Michael Paquier <[email protected]>
 2024-03-08 [d61a6cad6] Add support for DEFAULT in ALTER TABLE .. SET ACCESS MET


view thread (146+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: First draft of PG 17 release notes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox