From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Date: Fri, 18 Oct 2024 08:08:55 +0900
Message-ID: <ZxGZB2d-RttHwmlt@paquier.xyz> (raw)
In-Reply-To: <Zw_hxaDoC3TzQYjj@nathan>
References: <ZvGOPdGAronxOfmf@nathan>
<ZvI-WXcaFXuj1Dvp@paquier.xyz>
<ZvMSUPOqUU-VNADN@nathan>
<ZvOMBhlb5zrBCG5p@paquier.xyz>
<ZwV_DBQa8Qw6kKY2@nathan>
<Zw14zoBCg-zGu1mi@nathan>
<Zw8E73_nCk0DbO18@paquier.xyz>
<Zw8U0YU_fu2pcXs6@nathan>
<Zw8V0ClvZbUi2QQl@paquier.xyz>
<Zw_hxaDoC3TzQYjj@nathan>
On Wed, Oct 16, 2024 at 10:54:45AM -0500, Nathan Bossart wrote:
> Here is a new version of the patch set with this #ifdef added. I plan to
> give each of the code paths adjusted by 0001 a closer look, but otherwise
> I'm hoping to commit these soon.
0002 and 0003 look sane enough to me as shaped. I'd need to spend a
few more hours on 0001 if I were to do a second round on it, but you
don't really need a second opinion, do you? :D
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, exclusion@gmail.com, tgl@sss.pgh.pa.us, jkatz@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
In-Reply-To: <ZxGZB2d-RttHwmlt@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox