public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Remove useless casts to (void *)
Date: Thu, 31 Oct 2024 21:10:01 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Tue, Oct 29, 2024 at 10:20:03AM -0400, Tom Lane wrote:
> Peter Eisentraut <[email protected]> writes:
> > There are a bunch of (void *) casts in the code that don't make sense to 
> > me.  I think some of these were once necessary because char * was used 
> > in place of void * for some function arguments.  And some of these were 
> > probably just copied around without further thought.  I went through and 
> > cleaned up most of these.  I didn't find any redeeming value in these. 
> > They are just liable to hide actual problems such as incompatible types. 
> >   But maybe there are other opinions.
> 
> I don't recall details, but I'm fairly sure some of these prevented
> compiler warnings on some (old?) compilers.  Hard to be sure if said
> compilers are all gone.
> 
> Looking at the sheer size of the patch, I'm kind of -0.1, just
> because I'm afraid it's going to create back-patching gotchas.
> I don't really find that it's improving readability, though
> clearly that's a matter of opinion.

I kind of liked the patch in terms of simplifying things.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Remove useless casts to (void *)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox