public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: Kouber Saparev <[email protected]>
Cc: [email protected]
Subject: Re: BF mamba failure
Date: Fri, 15 Nov 2024 13:45:24 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<172854117093.1162.5418906857588663992.pgcf@coridan.postgresql.org>
<[email protected]>
<CAN4RuQtMHbVjWX-0sHOmVUxpsbMDX0tMndvfmNk-+ak4QBUWJg@mail.gmail.com>
<ZwjfckL/[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On Thu, Nov 14, 2024 at 10:07:41AM +0000, Bertrand Drouvot wrote:
> === 1
>
> Maybe use "generation" instead of generation in the comments (where it's not done,
> some comments do it already).
I've tweaked things to be more consistency, and applied that down to 15.
> === 2
>
> We could think about adding a test. That should be doable with replication slots
> or custom pgstats kinds and probably injection points. But I'm not sure that's
> worth it, as the code in the patch looks "simple" enough. Thoughts?
The tricky part is that this path involves a backend shutdown. We
should be able to do something with a wait before the dshash_find() in
pgstat_release_entry_ref() with a BackgroundPsql object that gets
stopped, but I'm not sure if we can guarantee a lookup of
pg_stat_activity at this stage. Let me see..
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: BF mamba failure
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox