From: Bruce Momjian <bruce@momjian.us>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: tgl@sss.pgh.pa.us
Cc: daniel@yesql.se
Cc: pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
Date: Mon, 18 Nov 2024 22:07:40 -0500
Message-ID: <ZzwA_DayripquW7e@momjian.us> (raw)
In-Reply-To: <20241119112907.1cdfe086df16e7ac173f9571@sraoss.co.jp>
References: <ZyUGLQ1jZ5MtRFnl@momjian.us>
<20241102.072700.1635141881080027242.ishii@postgresql.org>
<ZyWAJp3Ujb2LNFpk@momjian.us>
<20241102.120212.1541205818288992834.ishii@postgresql.org>
<ZyYmrwIUlDZuagb0@momjian.us>
<7491a14c-2215-46f0-87fe-ce30ae9eb4f6@eisentraut.org>
<20241111220215.8aef4df0f8d541df61abad57@sraoss.co.jp>
<Zzur1CWDmDe6lroJ@momjian.us>
<20241119112907.1cdfe086df16e7ac173f9571@sraoss.co.jp>
On Tue, Nov 19, 2024 at 11:29:07AM +0900, Yugo NAGATA wrote:
> On Mon, 18 Nov 2024 16:04:20 -0500
> > So, the failure of ligatures is caused usually by not using the right
> > Adobe Font Metric (AFM) file, I think. I have seen faulty ligature
> > rendering in PDFs but was alway able to fix it by using the right AFM
> > file. Odds are, failure is caused by using a standard Latin1 AFM file
> > and not the AFM file that matches the font being used.
> >
> > > [1] https://xmlgraphics.apache.org/fop/faq.html#pdf-characters
> > >
> > > However, it seems that using iconv to detect non-Latin1 characters may be still
> > > useful because these are likely not displayed in PDF. For example, we can do this
> > > in make check as the attached patch 0002. It cannot show the filname where one
> > > is found, though.
> >
> > I was thinking something like:
> >
> > grep -l --recursive -P '[\x80-\xFF]' . |
> > while read FILE
> > do iconv -f UTF-8 -t ISO-8859-1 "$FILE" || exit 1
> > done
> >
> > This only checks files with non-ASCII characters.
>
> Checking non-latin1 after non-ASCII characters seems good idea.
> I attached a updated patch (0002) that uses perl instead of grep
> because non-GNU grep could not have escape sequences for hex.
Yes, good point.
> > So, are we sure this will be the message even for non-English users? I
> > thought checking for warning message text was too fragile.
>
> I am not sure whether fop has messages in non-English, although I've never
> seen Japanese messages output.
>
> I wonder we can get unified results if executed with LANG=C.
> The updated patch 0001 is fixed in this direction.
Yes, good idea.
> + @ ( $(PERL) -ne '/[\x80-\xFF]/ and `${ICONV} -t ISO-8859-1 -f UTF-8 "$$ARGV" 2>/dev/null` and print("$$ARGV:$$_"),$$n++; END {exit($$n>0)}' \
I am thinking we should have -f before -t becaues it is from/to.
I like this approach.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, nagata@sraoss.co.jp, peter@eisentraut.org, ishii@postgresql.org, tgl@sss.pgh.pa.us, daniel@yesql.se
Subject: Re: Doc: typo in config.sgml
In-Reply-To: <ZzwA_DayripquW7e@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox