From: Drouvot, Bertrand <bdrouvot@amazon.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: sawada.mshk@gmail.com
Cc: alvherre@alvh.no-ip.org
Cc: masahiko.sawada@2ndquadrant.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Add Information during standby recovery conflicts
Date: Fri, 8 Jan 2021 06:15:26 +0100
Message-ID: <a0156f3c-0f42-fef2-3189-8463f86e5035@amazon.com> (raw)
In-Reply-To: <665ebdf3-d517-18c6-6b32-06fcdd9d6f83@oss.nttdata.com>
References: <8c1fca5b-6c5c-df6f-0b6d-4702eeb11c5c@amazon.com>
<02295c62-e90f-9bf7-63ba-1ccda204aa71@oss.nttdata.com>
<fd057da9-5616-e10e-fae6-75a85b89be68@oss.nttdata.com>
<20210108.111712.1465719681094712823.horikyota.ntt@gmail.com>
<665ebdf3-d517-18c6-6b32-06fcdd9d6f83@oss.nttdata.com>
Hi,
On 1/8/21 5:19 AM, Fujii Masao wrote:
>
> On 2021/01/08 11:17, Kyotaro Horiguchi wrote:
>> At Fri, 8 Jan 2021 01:32:11 +0900, Fujii Masao
>> <masao.fujii@oss.nttdata.com> wrote in
>>>
>>> Attached is the updated version of the patch. This can be applied to
>>> current master.
>>>
>>> With the patch, for example, if the startup process waited longer than
>>> deadlock_timeout for the recovery conflict on the lock, the latter log
>>> message in the followings would be additionally output.
>>>
>>> LOG: recovery still waiting after 1001.223 ms: recovery
>>> conflict on
>>> lock
>>> LOG: recovery finished waiting after 19004.694 ms: recovery
>>> conflict
>>> on lock
>>
>> + /*
>> + * Emit the log message if recovery conflict on
>> buffer pin was resolved but
>> + * the startup process waited longer than
>> deadlock_timeout for it.
>>
>> The first line is beyond the 80th column.
>
> Thanks for pointing out this! This happened because I forgot to run
> pgindent
> for bufmgr.c. Attached is the updated version of the patch.
The patch looks good to me.
Bertrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bdrouvot@amazon.com, masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com, sawada.mshk@gmail.com, alvherre@alvh.no-ip.org, masahiko.sawada@2ndquadrant.com
Subject: Re: Add Information during standby recovery conflicts
In-Reply-To: <a0156f3c-0f42-fef2-3189-8463f86e5035@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox