From: Andrei Lepikhov <lepihov@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add Postgres module info
Date: Thu, 12 Dec 2024 11:35:56 +0700
Message-ID: <a0872eec-1596-466f-8e15-0540a29528c4@gmail.com> (raw)
In-Reply-To: <Z1pcItMVcXCInp_v@paquier.xyz>
References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com>
<506788.1733941263@sss.pgh.pa.us>
<2qdclwljzvw5abfvo4porr3ehox32icrbtfjaum327ruxts6qm@udexcbweewpq>
<e0e12947-6dfb-4c3a-b6ad-5682a880cda4@app.fastmail.com>
<556165.1733967268@sss.pgh.pa.us>
<Z1pXd_dleBGIiVR3@paquier.xyz>
<570943.1733974778@sss.pgh.pa.us>
<Z1pcItMVcXCInp_v@paquier.xyz>
On 12/12/24 10:44, Michael Paquier wrote:
> On Wed, Dec 11, 2024 at 10:39:38PM -0500, Tom Lane wrote:
>> Michael Paquier <michael@paquier.xyz> writes:
>>> Presumably,
>>> the extra tracking can be done in dfmgr.c with more fields added to
>>> DynamicFileList to track the information involved.
>>
>> I wouldn't add any overhead to the normal case for this. Couldn't
>> we walk the list and re-fetch each module's magic block inside
>> this new function?
>
> Depends on how much we should try to cache to make that less expensive
> on repeated calls because we cannot unload libraries, but sure, I
> don't see why we could not that for each SQL function call to simplify
> the logic and the structures in place.
I want to say that 'cannot unload libraries' is a negative outcome of
the architecture. It would be better to invent something like
PG_unregister, allowing libraries to at least return a hook routine call
back to the system.
So, maybe it makes sense to design this feature with re-fetching
libraries, supposing it is already implemented somehow and elements of
the DynamicFileList may be removed.
--
regards, Andrei Lepikhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: lepihov@gmail.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, euler@eulerto.com, andres@anarazel.de
Subject: Re: Add Postgres module info
In-Reply-To: <a0872eec-1596-466f-8e15-0540a29528c4@gmail.com>
References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com> <506788.1733941263@sss.pgh.pa.us> <2qdclwljzvw5abfvo4porr3ehox32icrbtfjaum327ruxts6qm@udexcbweewpq> <e0e12947-6dfb-4c3a-b6ad-5682a880cda4@app.fastmail.com> <556165.1733967268@sss.pgh.pa.us> <Z1pXd_dleBGIiVR3@paquier.xyz> <570943.1733974778@sss.pgh.pa.us> <Z1pcItMVcXCInp_v@paquier.xyz> <a0872eec-1596-466f-8e15-0540a29528c4@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox