pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dmitry Ivanov <d.ivanov@postgrespro.ru>
To: Aleksandr Parfenov <a.parfenov@postgrespro.ru>
Cc: David Steele <david@pgmasters.net>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: new function for tsquery creartion
Date: Mon, 26 Mar 2018 11:51:42 +0300
Message-ID: <a1686708fc7d43d9a2de19c1697ac57e@postgrespro.ru> (raw)
In-Reply-To: <20180326092405.71820cf2@asp437-24-g082ur>
References: <fe931111ff7e9ad79196486ada79e268@postgrespro.ru>
	<20180302030605.5ur6ktkb2vyb46pb@alap3.anarazel.de>
	<152025433949.1548.16466871234054596674.pgcf@coridan.postgresql.org>
	<34280367-0dab-7f73-8d7c-d21c7276814b@pgmasters.net>
	<8df9de83119eb295f3424c573d64ff84@postgrespro.ru>
	<20180326092405.71820cf2@asp437-24-g082ur>

> Recently I worked with the old version of the patch and found a bug.
> So, I think it is better to notify you immediately, so you can fix it 
> in
> rebased/revised version.
> 
> I noticed, that operator AROUND(N) works only
> in case of non-negative operands. If any of the operands is negative, 
> it
> behaves as phrase operator <N>. It is caused by lack of TS_NOT_EXAC
> flag and AROUND(N) operator check in function TS_phrase_execute in
> branches for negated operands.

Good to know, thanks! To be honest, I' sure that Theodor is right: it's 
better to implement AROUND(N) operator using <N, M> when it's committed. 
The following version of patch won't support AROUND(N). I have to fix a 
few more questionable things, though.

-- 
Dmitry Ivanov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




view thread (36+ messages)  latest in thread

Message-ID: <a1686708fc7d43d9a2de19c1697ac57e@postgrespro.ru>
Permalink:  ../a1686708fc7d43d9a2de19c1697ac57e@postgrespro.ru/
Also on:    postgresql.org/message-id/a1686708fc7d43d9a2de19c1697ac57e@postgrespro.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: d.ivanov@postgrespro.ru, a.parfenov@postgrespro.ru, david@pgmasters.net, a.alekseev@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: new function for tsquery creartion
  In-Reply-To: <a1686708fc7d43d9a2de19c1697ac57e@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox