pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Yura Sokolov <y.sokolov@postgrespro.ru>
To: Julien Tachoires <julien@tachoires.me>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Allow table AMs to define their own reloptions
Date: Tue, 4 Mar 2025 12:19:53 +0300
Message-ID: <a3697813-d5cf-40c4-b5a1-91a7605db570@postgrespro.ru> (raw)
In-Reply-To: <20250304061619.l3d352kbgy7fwl5c@poseidon.home.virt>
References: <20250302085641.hmjom5ru3w554t2n@poseidon.home.virt>
	<20250302132354.ffbfokeq36dp2kss@poseidon.home.virt>
	<acdd20d4-cc28-4f77-bade-d5b048380b50@postgrespro.ru>
	<20250304061619.l3d352kbgy7fwl5c@poseidon.home.virt>

04.03.2025 09:16, Julien Tachoires пишет:
> Hi Yura,
> 
> On Sun, Mar 02, 2025 at 06:20:07PM +0300, Yura Sokolov wrote:
>> Your forgot another one attempt discussion with patch [1] with alive
>> commitfest entry [2]
>>
>> [1] https://postgr.es/m/flat/3766675.7eaCOWfIcx%40thinkpad-pgpro
>> [2] https://commitfest.postgresql.org/patch/4688/
> 
> Thank you. After taking a look at the patch itself and the email thread,
> it seems this patch does not add custom reloptions to table AMs, see
> [1].
> 
> [1]: https://www.postgresql.org/message-id/1823308.yXV3o4JbTB%40thinkpad-pgpro

But intention of this patch is to make adding options easier, as author says:

  But new option engine will make adding custom options for table AM more
  easy task, as main goal of this patch is to  simplify adding options
  everywhere they needed. And yes, adding custom table AM options is one of
  my next goals, as soon as this patch is commit.

I believe, adding generic way to options extension is better way than
targeting specific options. Don't you?

I believe Nikolay's patch needs review and support. As you're interesting
to the problem, may you at least look at his suggestion and analyze it from
the point of view of your task?

-------
regards
Yura Sokolov aka funny-falcon





view thread (39+ messages)  latest in thread

Message-ID: <a3697813-d5cf-40c4-b5a1-91a7605db570@postgrespro.ru>
Permalink:  ../a3697813-d5cf-40c4-b5a1-91a7605db570@postgrespro.ru/
Also on:    postgresql.org/message-id/a3697813-d5cf-40c4-b5a1-91a7605db570@postgrespro.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: y.sokolov@postgrespro.ru, julien@tachoires.me
  Subject: Re: Allow table AMs to define their own reloptions
  In-Reply-To: <a3697813-d5cf-40c4-b5a1-91a7605db570@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox