From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Shinya11.Kato@nttdata.com, PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion
Date: Thu, 14 Jan 2021 15:43:25 +0900
Message-ID: <a5546203-6567-5cab-c8ea-6c97b3f137cb@oss.nttdata.com> (raw)
In-Reply-To: <CAD21AoDeEpD9R1PYFGxW56iyNn8s0jzuvtXhNJb_vOoot0dihA@mail.gmail.com>
References: <b0e4c5c53ef84c5395524f5056fc71f0@MP-MSGSS-MBX001.msg.nttdata.co.jp>
<CAD21AoBRw9FY6oNj8ubY7XEwJ9Bprfehu88_ePbCfH93JLxWsw@mail.gmail.com>
<7559e8ee8a0644c8aad79837092143c7@MP-MSGSS-MBX001.msg.nttdata.co.jp>
<CAD21AoCCQDXqPwJy08An23VOUSxtd+HLfHPYZ0n2eAXM8MKepg@mail.gmail.com>
<28d43417-af7f-c3b8-da19-189a50d2d85c@enterprisedb.com>
<CAD21AoBf8fUg7MvBAau2wsEKOTMgpgJmneOJCbt4=4ba1hc_EA@mail.gmail.com>
<CAHGQGwFPJOT5164fTSDWQ-WOAqaLqS39Y+ri0eRk_H_OxJnkVA@mail.gmail.com>
<CAHGQGwGMEzUCW5OXFPMOe910T7E_Cz2PEpt2_=LFw6i=5mzF-Q@mail.gmail.com>
<CAD21AoDeEpD9R1PYFGxW56iyNn8s0jzuvtXhNJb_vOoot0dihA@mail.gmail.com>
On 2021/01/14 14:38, Masahiko Sawada wrote:
> On Wed, Jan 13, 2021 at 1:55 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>>
>> On Tue, Jan 12, 2021 at 11:09 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>>>
>>> On Tue, Jan 12, 2021 at 10:00 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>>
>>>> On Mon, Jan 11, 2021 at 11:00 PM Peter Eisentraut
>>>> <peter.eisentraut@enterprisedb.com> wrote:
>>>>>
>>>>> On 2021-01-05 10:56, Masahiko Sawada wrote:
>>>>>> BTW according to the documentation, the options of DECLARE statement
>>>>>> (BINARY, INSENSITIVE, SCROLL, and NO SCROLL) are order-sensitive.
>>>>>>
>>>>>> DECLARE name [ BINARY ] [ INSENSITIVE ] [ [ NO ] SCROLL ]
>>>>>> CURSOR [ { WITH | WITHOUT } HOLD ] FOR query
>>>>>>
>>>>>> But I realized that these options are actually order-insensitive. For
>>>>>> instance, we can declare a cursor like:
>>>>>>
>>>>>> =# declare abc scroll binary cursor for select * from pg_class;
>>>>>> DECLARE CURSOR
>>>>>>
>>>>>> The both parser code and documentation has been unchanged from 2003.
>>>>>> Is it a documentation bug?
>>>>>
>>>>> According to the SQL standard, the ordering of the cursor properties is
>>>>> fixed. Even if the PostgreSQL parser offers more flexibility, I think
>>>>> we should continue to encourage writing the clauses in the standard order.
>>>>
>>>> Thanks for your comment. Agreed.
>>>>
>>>> So regarding the tab completion for DECLARE statement, perhaps it
>>>> would be better to follow the documentation?
>>>
>>> IMO yes because it's less confusing to make the document and
>>> tab-completion consistent.
>
> Agreed.
>
>>
>> I updated the patch that way. Could you review this version?
>
> Thank you for updating the patch. Looks good to me.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, sawada.mshk@gmail.com, masao.fujii@gmail.com, peter.eisentraut@enterprisedb.com
Subject: Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion
In-Reply-To: <a5546203-6567-5cab-c8ea-6c97b3f137cb@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox