pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Subject: Re: [POC] Fast COPY FROM command for the table with foreign partitions
Date: Tue, 28 Jul 2020 05:33:19 +0500
Message-ID: <a5729617-c16d-03d8-4b60-3910720e0a46@postgrespro.ru> (raw)
In-Reply-To: <08721da1dc2da7c0e275593b4f8d9037@postgrespro.ru>
References: <3d0909dc-3691-a576-208a-90986e55489f@postgrespro.ru>
	<CAPmGK15mAiaU85OcvEDE=7fHA3PvA7ChP82b7bEE57Yw20rF4A@mail.gmail.com>
	<7a3c3bdd-dc43-68a7-7cc5-ae139f1de4a7@postgrespro.ru>
	<CAExHW5uAtyAVL-iuu1Hsd0fycqS5UHoHCLfauYDLQwRucwC9Og@mail.gmail.com>
	<bd29904a-4ad3-3619-eb0c-ff04f524f7a1@postgrespro.ru>
	<CAG-ACPUZ1FRwkRfOnBZN0PYvXSZrBRgaExyRT4QHaN20rf7A8Q@mail.gmail.com>
	<ae25e79e-6122-720e-1349-fb832c6021df@postgrespro.ru>
	<CA+HiwqH2ehGurL9bYUydXBxVUH6aHN5yXXxESAOs9O6-f_+Qeg@mail.gmail.com>
	<f5a6c34e-d069-3d4d-d7ea-6d965b85e9e6@postgrespro.ru>
	<08721da1dc2da7c0e275593b4f8d9037@postgrespro.ru>



27.07.2020 21:34, Alexey Kondratov пишет:
> Hi Andrey,
> 
> On 2020-07-23 09:23, Andrey V. Lepikhov wrote:
>> On 7/16/20 2:14 PM, Amit Langote wrote:
>>> Amit Langote
>>> EnterpriseDB: http://www.enterprisedb.com
>>>
>>
>> Version 5 of the patch. With changes caused by Amit's comments.
> 
> Just got a segfault with your v5 patch by deleting from a foreign table. 
> It seems that ShutdownForeignScan inside node->fdwroutine doesn't have a 
> correct pointer to the required function.
> 
> I haven't had a chance to look closer on the code, but you can easily 
> reproduce this error with the attached script (patched Postgres binaries 
> should be available in the PATH). It works well with master and fails 
> with your patch applied.

I used master a3ab7a707d and v5 version of the patch with your script.
No errors found. Can you check your test case?

-- 
regards,
Andrey Lepikhov
Postgres Professional





view thread (84+ messages)  latest in thread

Message-ID: <a5729617-c16d-03d8-4b60-3910720e0a46@postgrespro.ru>
Permalink:  ../a5729617-c16d-03d8-4b60-3910720e0a46@postgrespro.ru/
Also on:    postgresql.org/message-id/a5729617-c16d-03d8-4b60-3910720e0a46@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lepikhov@postgrespro.ru, a.kondratov@postgrespro.ru, amitlangote09@gmail.com, ashutosh.bapat@2ndquadrant.com, ashutosh.bapat.oss@gmail.com, etsuro.fujita@gmail.com
  Subject: Re: [POC] Fast COPY FROM command for the table with foreign partitions
  In-Reply-To: <a5729617-c16d-03d8-4b60-3910720e0a46@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox