pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Nikhil Sontakke <nikhils@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Sokolov Yura <y.sokolov@postgrespro.ru>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: Wed, 31 Oct 2018 01:08:58 +0100
Message-ID: <a5ba1686-bb79-f2c3-568d-993e4c53b920@2ndquadrant.com> (raw)
In-Reply-To: <CAMGcDxfVBiBXt4F7v58_DfqFD9xnmU8hBEiyqoypon6Ftroe_Q@mail.gmail.com>
References: <20180719194208.j5m7qhdmqp46d6yg@alap3.anarazel.de>
	<20180719223500.lclj45aiojikwnwm@alap3.anarazel.de>
	<CAMGcDxfgg8yP0MsdKRuqwihkrQF=0Mz9Se+0paNGADWaexULjQ@mail.gmail.com>
	<20180720145836.gxwhbftuoyx5h4gc@alap3.anarazel.de>
	<CAMGcDxebtC_ZO6EtLA1MgJ6sWbud3Fjtq9HsBwxxhYfoHJdANw@mail.gmail.com>
	<20180723135009.w25re6qxbb7njrbd@alap3.anarazel.de>
	<CAMGcDxdJNZVq1mX9dZbwEniigi=af8H5dt62C+q2UHwsE+BTaw@mail.gmail.com>
	<20180723141435.ercxxh3bj2uc2mjm@alap3.anarazel.de>
	<3B37B16B-A473-4352-ABCF-F23AE314D4F7@2ndquadrant.com>
	<CAMGcDxeBcMBF0KZ9qMpcb07uX6uLNO5hk=VWCQC514oZuofLmw@mail.gmail.com>
	<20180726200241.aje4dv4jsv25v4k2@alap3.anarazel.de>
	<CAMGcDxfVBiBXt4F7v58_DfqFD9xnmU8hBEiyqoypon6Ftroe_Q@mail.gmail.com>

Hi Nikhil,

Any progress on the issues discussed in the last couple of messages?
That is:

1) removing of the sleep() from tests

2) changes to systable_getnext() wrt. TransactionIdIsInProgress()

3) adding asserts / checks to codepaths not going through systable_*

4) (not) adding this as a per-plugin option

5) handling cases where the downstream does not have 2PC enabled

I guess it'd be good an updated patch or further discussion before
continuing the review efforts.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (644+ messages)  latest in thread

Message-ID: <a5ba1686-bb79-f2c3-568d-993e4c53b920@2ndquadrant.com>
Permalink:  ../a5ba1686-bb79-f2c3-568d-993e4c53b920@2ndquadrant.com/
Also on:    postgresql.org/message-id/a5ba1686-bb79-f2c3-568d-993e4c53b920@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, nikhils@2ndquadrant.com, andres@anarazel.de, robertmhaas@gmail.com, david@pgmasters.net, andrew.dunstan@2ndquadrant.com, simon@2ndquadrant.com, craig@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, petr.jelinek@2ndquadrant.com, y.sokolov@postgrespro.ru, s.kelvich@postgrespro.ru, 9erthalion6@gmail.com, tgl@sss.pgh.pa.us, sawada.mshk@gmail.com
  Subject: Re: [HACKERS] logical decoding of two-phase transactions
  In-Reply-To: <a5ba1686-bb79-f2c3-568d-993e4c53b920@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox