From: Jacob Champion <pchampion@vmware.com>
To: peter.eisentraut@enterprisedb.com <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log details for client certificate failures
Date: Tue, 3 May 2022 23:05:30 +0000
Message-ID: <a922e857c4e4a073f219bc5005b862eb22255c20.camel@vmware.com> (raw)
In-Reply-To: <cd03fa63-d4d9-8d3b-f9f5-13206a28d888@enterprisedb.com>
References: <d13c4a5787c2a3f83705124f0391e0738c796751.camel@vmware.com>
<cd03fa63-d4d9-8d3b-f9f5-13206a28d888@enterprisedb.com>
On Tue, 2022-05-03 at 21:06 +0200, Peter Eisentraut wrote:
> The information in pg_stat_ssl is limited to NAMEDATALEN (see struct
> PgBackendSSLStatus).
>
> It might make sense to align what your patch prints to identify
> certificates with what is shown in that view.
Sure, a max length should be easy enough to do. Is there a reason to
limit to NAMEDATALEN specifically? I was under the impression that we
would rather not have had that limitation in the stats framework, if we
could have avoided it. (In particular I think NAMEDATALEN will cut off
the longest possible Common Name by just five bytes.)
Thanks,
--Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pchampion@vmware.com, peter.eisentraut@enterprisedb.com
Subject: Re: [PATCH] Log details for client certificate failures
In-Reply-To: <a922e857c4e4a073f219bc5005b862eb22255c20.camel@vmware.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox