pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jonathan S. Katz <jkatz@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Christoph Berg <myon@debian.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: How about a psql backslash command to show GUCs?
Date: Tue, 12 Apr 2022 15:40:49 -0400
Message-ID: <a93f754c-e020-b330-9104-d8f3ce6ea654@postgresql.org> (raw)
In-Reply-To: <816940.1649782841@sss.pgh.pa.us>
References: <FF230C05-B27A-4C7B-8514-A5A21EA3D7CC@enterprisedb.com>
	<3370142.1649348973@sss.pgh.pa.us>
	<2DB6EB50-04DF-49D1-BB5B-61C62898BB35@enterprisedb.com>
	<3370992.1649349445@sss.pgh.pa.us>
	<711e43b9-6499-6a8b-0802-fb549874658e@joeconway.com>
	<CAKFQuwb6Ju1VM+hOV2hEbSzoW40o33qp12CQUGRhS+js=vYaew@mail.gmail.com>
	<CAFj8pRA2aEY+SRjZ_WurB8512Etry3Arefv_L7fkpHW-ct3kkQ@mail.gmail.com>
	<3400691.1649363759@sss.pgh.pa.us>
	<YlFQLzlPi4QD0wSi@msg.df7cb.de>
	<4105551.1649514677@sss.pgh.pa.us>
	<YlGtICTMIJ886Ij3@jrouhaud>
	<afad841b-cc31-1784-84f7-b6c3c71d0c5d@postgresql.org>
	<4115803.1649521632@sss.pgh.pa.us>
	<043bcb40-052f-5c85-63ff-d6a2b5a0b7ca@postgresql.org>
	<495595.1649704355@sss.pgh.pa.us>
	<9439380b-a81f-c910-f527-db4d470b026b@postgresql.org>
	<531275.1649707882@sss.pgh.pa.us>
	<7bba5a32-65fe-04e1-7c36-efd963a625c9@postgresql.org>
	<807242.1649776780@sss.pgh.pa.us>
	<c52349d9-297d-1be2-b524-50001b55ca70@postgresql.org>
	<816940.1649782841@sss.pgh.pa.us>

On 4/12/22 1:00 PM, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>> On 4/12/22 11:19 AM, Tom Lane wrote:
>>> It'd just look like this, I think.  I see from looking at guc.c that
>>> boot_val can be NULL, so we'd better use IS DISTINCT FROM.
> 
>> I tested it and I like this a lot better, at least it's much more
>> consolidated. They all seem to be generated (directories, timezones,
>> collations/encodings).
> 
> Yeah, most of what shows up in a minimally-configured installation is
> postmaster-computed settings like config_file, rather than things
> that were actually set by the DBA.  Personally I'd rather hide the
> ones that have source = 'override', but that didn't seem to be the
> consensus.

The list seems more reasonable now, though now that I'm fully in the 
"less is more" camp based on the "non-defaults" description, I think 
anything we can do to further prune is good.

>> The one exception to this seems to be "max_stack_depth", which is
>> rendering on my "\dconfig" though I didn't change it, an it's showing
>> it's default value of 2MB. "boot_val" says 100, "reset_val" says 2048,
>> and it's commented out in my postgresql.conf. Do we want to align that?
> 
> I don't think there's any principled thing we could do about that in
> psql.  The boot_val is a conservatively small 100kB, but we crank
> that up automatically based on getrlimit(RLIMIT_STACK), so on any
> reasonable platform it's going to show as not being default.

Got it.

We may be at a point where it's "good enough" and let more people chime 
in during beta.

Thanks,

Jonathan


Attachments:

  OpenPGP_signature (application/pgp-signature, 839B) download

view thread (71+ messages)  latest in thread

Message-ID: <a93f754c-e020-b330-9104-d8f3ce6ea654@postgresql.org>
Permalink:  ../a93f754c-e020-b330-9104-d8f3ce6ea654@postgresql.org/
Also on:    postgresql.org/message-id/a93f754c-e020-b330-9104-d8f3ce6ea654@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: jkatz@postgresql.org, tgl@sss.pgh.pa.us, rjuju123@gmail.com, myon@debian.org, pavel.stehule@gmail.com, david.g.johnston@gmail.com, mail@joeconway.com, mark.dilger@enterprisedb.com, andrew@dunslane.net, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org
  Subject: Re: How about a psql backslash command to show GUCs?
  In-Reply-To: <a93f754c-e020-b330-9104-d8f3ce6ea654@postgresql.org>
  References: <FF230C05-B27A-4C7B-8514-A5A21EA3D7CC@enterprisedb.com> <2DB6EB50-04DF-49D1-BB5B-61C62898BB35@enterprisedb.com> <3370992.1649349445@sss.pgh.pa.us> <711e43b9-6499-6a8b-0802-fb549874658e@joeconway.com> <CAKFQuwb6Ju1VM+hOV2hEbSzoW40o33qp12CQUGRhS+js=vYaew@mail.gmail.com> <CAFj8pRA2aEY+SRjZ_WurB8512Etry3Arefv_L7fkpHW-ct3kkQ@mail.gmail.com> <3400691.1649363759@sss.pgh.pa.us> <YlFQLzlPi4QD0wSi@msg.df7cb.de> <4105551.1649514677@sss.pgh.pa.us> <YlGtICTMIJ886Ij3@jrouhaud> <afad841b-cc31-1784-84f7-b6c3c71d0c5d@postgresql.org> <4115803.1649521632@sss.pgh.pa.us> <043bcb40-052f-5c85-63ff-d6a2b5a0b7ca@postgresql.org> <495595.1649704355@sss.pgh.pa.us> <9439380b-a81f-c910-f527-db4d470b026b@postgresql.org> <531275.1649707882@sss.pgh.pa.us> <7bba5a32-65fe-04e1-7c36-efd963a625c9@postgresql.org> <807242.1649776780@sss.pgh.pa.us> <c52349d9-297d-1be2-b524-50001b55ca70@postgresql.org> <816940.1649782841@sss.pgh.pa.us> <a93f754c-e020-b330-9104-d8f3ce6ea654@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox