public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Andres Freund <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: [email protected]
Subject: Re: Defend against -ffast-math in meson builds
Date: Wed, 11 Mar 2026 15:07:10 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <vwnxbsap65km373ghtqhhvhwnc35suwraegb7z5op4okxyuwzu@kpaumampogpe>
References: <[email protected]>
	<vwnxbsap65km373ghtqhhvhwnc35suwraegb7z5op4okxyuwzu@kpaumampogpe>

On 11.03.26 14:43, Andres Freund wrote:
> Hi,
> 
> On 2026-03-11 11:52:28 +0000, Bertrand Drouvot wrote:
>> while working on a patch (not shared yet), I had issues with floating-point and
>> realized that we don't defend against -ffast-math in meson builds. We defend
>> against in autoconf (because we don't want fast-math optimizations [1]), so the
>> attached does the same for meson.
> 
> I don't find this (nor the autoconf check) particularly likely to be
> helpful. The most likely way the flag would unintentionally be added would be
> via the cflags of some dependency - which won't be picked up by the tests.
> 
> However we do have tests during the builds that should pick it up, in date.c
> and timestamp.c...

The existing check in configure is because certain Linux distributions 
used to compile everything with -ffast-math to be "faster", and that 
kept breaking PostgreSQL and so we wanted to stop them very early. 
These are gone, and the defenses in the code like date.c should be 
sufficient for any new attempts.  I think we could remove the check in 
configure.

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Defend against -ffast-math in meson builds
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox