public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bertrand Drouvot <[email protected]>
To: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: Defend against -ffast-math in meson builds
Date: Fri, 13 Mar 2026 09:18:59 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<vwnxbsap65km373ghtqhhvhwnc35suwraegb7z5op4okxyuwzu@kpaumampogpe>
<[email protected]>
<[email protected]>
<abGPko4lPv/[email protected]>
<[email protected]>
<dx5yldtsqih2htsd7cz3tfxt5zhuggpeegwllz7wz2r26tll5h@cwhsw4ddfbc5>
<[email protected]>
<[email protected]>
Hi,
On Thu, Mar 12, 2026 at 11:10:51AM -0400, Tom Lane wrote:
> Bertrand Drouvot <[email protected]> writes:
> > On Wed, Mar 11, 2026 at 01:48:31PM -0400, Andres Freund wrote:
> >> On 2026-03-11 12:45:55 -0400, Tom Lane wrote:
> >>> So no, I don't wanna support this. But maybe we should move the
> >>> code-level tests out of the datetime files and into utils/float.h
> >>> or some such place.
>
> >> I think it's probably better to have it in a .c file (maybe float.c), I could
> >> kinda imagine some extension intentionally enabling -ffast-math, because it
> >> does something numerically intensive where the incorrectness doesn't matter.
>
> > I think that you have a good point about the extension. That said a .h file
> > could also prevent the extension to make use of -ffast-math "accidentally".
>
> Yeah, that was my thought too. But I think Andres has a point that in
> principle an extension could use -ffast-math intentionally, so I'm
> content to just put the test in float.c.
Yeah, I do agree. Something like in the attached?
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (14+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Defend against -ffast-math in meson builds
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox