pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Hannu Krosing <hannuk@google.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
Date: Tue, 8 Jul 2025 16:06:16 -0500
Message-ID: <aG2ISJC__3lQwRqY@nathan> (raw)
In-Reply-To: <CAMT0RQTXiqH7zdQEVSVd2L7_Cw4wQ1eHOD8hfZ+0vecMXJWc-w@mail.gmail.com>
References: <CAMT0RQRL08=Si+9V7RW7VKcbo2H7GO6ME3opkS_WHpE8qctBLg@mail.gmail.com>
	<Z_VE4Q4A2nNCX3Ny@nathan>
	<4044567.1744128814@sss.pgh.pa.us>
	<CAMT0RQSALxZ2DJbq0b5cy+cvmpVxkawmv7c+qTWYObubZVr+2g@mail.gmail.com>
	<4047312.1744130263@sss.pgh.pa.us>
	<Z_VTucTiS01p-d6z@nathan>
	<4050387.1744132029@sss.pgh.pa.us>
	<aBkQLSkx1zUJ-LwJ@nathan>
	<aBtzZ4PyccUVCcyA@nathan>
	<CAMT0RQTXiqH7zdQEVSVd2L7_Cw4wQ1eHOD8hfZ+0vecMXJWc-w@mail.gmail.com>

On Sun, Jul 06, 2025 at 02:48:08PM +0200, Hannu Krosing wrote:
> Did a quick check of the patch and it seems to work ok.

Thanks for taking a look.

> What do you think of the idea of not dumping pg_shdepend here, but
> instead adding the required entries after loading
> pg_largeobject_metadata based on the contents of it ?

While not dumping it might save a little space during upgrade, the query
seems to be extremely slow.  So, I don't see any strong advantage.

-- 
nathan





view thread (48+ messages)  latest in thread

Message-ID: <aG2ISJC__3lQwRqY@nathan>
Permalink:  ../aG2ISJC__3lQwRqY@nathan/
Also on:    postgresql.org/message-id/aG2ISJC__3lQwRqY@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, hannuk@google.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
  In-Reply-To: <aG2ISJC__3lQwRqY@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox