From: Nathan Bossart <nathandbossart@gmail.com>
To: Hannu Krosing <hannuk@google.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nitin Motiani <nitinmotiani@google.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
Date: Tue, 19 Aug 2025 14:18:40 -0500
Message-ID: <aKTOEGwYP1QbzE1K@nathan> (raw)
In-Reply-To: <CAMT0RQT_Z8thT69nNLO7ZNickOX_QT=8rKfZseksowopB-XvUg@mail.gmail.com>
References: <aJ3_Gih_XW1_O2HF@nathan>
<CAMT0RQT_Z8thT69nNLO7ZNickOX_QT=8rKfZseksowopB-XvUg@mail.gmail.com>
On Tue, Aug 19, 2025 at 09:49:26AM +0200, Hannu Krosing wrote:
> Have you considered re-creating pg_shdepend from
> pg_largeobject_metadata directly instead of having special cases for
> dumping it ?
I considered it when you last brought up the idea [0], but my testing
indicated that it's measurably slower.
> It would also be useful in cases of old (pg_upgraded since before pg
> 12) databases which might be missing it anyway.
We only use COPY for upgrades from v12 and newer, and the patch at hand
only applies to v16 and newer. There should be no need to repair
pg_shdepend for any such upgrades because we haven't copied/linked the
files since before v12.
[0] https://postgr.es/m/CAMT0RQTXiqH7zdQEVSVd2L7_Cw4wQ1eHOD8hfZ%2B0vecMXJWc-w%40mail.gmail.com
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, hannuk@google.com, tgl@sss.pgh.pa.us, nitinmotiani@google.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
In-Reply-To: <aKTOEGwYP1QbzE1K@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox