pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Rahila Syed <rahilasyed90@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improve LWLock tranche name visibility across backends
Date: Fri, 29 Aug 2025 11:02:02 -0500
Message-ID: <aLHO-jh-spXWG1pt@nathan> (raw)
In-Reply-To: <CAA5RZ0vw-r1qjHw5hUNTzAyCiK3KQ-r+G5ECfWSn+qjdu-fpnw@mail.gmail.com>
References: <CAA5RZ0uYpXw8yTpCPiDAvwt9WtXesKM_vebbCjBm4MQBVnchMw@mail.gmail.com>
	<CAA5RZ0u=Fb8dDdPrEzawYjVqAmYB_PTP4Yy3tV78=_gcvXrjjA@mail.gmail.com>
	<aK4Vr0puSQqPI5vS@nathan>
	<CAA5RZ0v=vvzn4mvejQVA1iFabxSTUQZPDuTCAF0WqA41LKns7g@mail.gmail.com>
	<aK7PyCbPib+/JO2+@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAA5RZ0ve-fHuNYW-ruMwg1y1v7-aCqMm_MiNq1KOdg2Y2-pKDw@mail.gmail.com>
	<aLAFhwpzEwbjiWLG@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAA5RZ0s4ip08Lsk=aYuXGCkBr78jhH=gOau939mhAp-rGuNC3Q@mail.gmail.com>
	<aLCEo0ZMV3vIGRWk@nathan>
	<CAA5RZ0vw-r1qjHw5hUNTzAyCiK3KQ-r+G5ECfWSn+qjdu-fpnw@mail.gmail.com>

On Thu, Aug 28, 2025 at 05:53:23PM -0500, Sami Imseih wrote:
>> I think this patch set will require reworking the "GetNamedLWLockTranche
>> crashes on Windows in normal backend" patch [0], but AFAICT we can easily
>> adjust it to scan through NamedLWLockTrancheNames instead.
> 
> Except, we will need to turn the char**NamedLWLockTranche into a struct
> that will hold the num_lwlocks as well. Something like. But that is doable.

Ah, right.

> If there is no interest to backpatch [0], maybe we should just make this
> change as part of this patch set. What do you think? I can make this change
> in v18.

I think we should keep that separate.  I don't see any benefit to combining
it, and it'd be good to keep the discussion in a single thread in the
archives for future reference.

-- 
nathan





view thread (107+ messages)  latest in thread

Message-ID: <aLHO-jh-spXWG1pt@nathan>
Permalink:  ../aLHO-jh-spXWG1pt@nathan/
Also on:    postgresql.org/message-id/aLHO-jh-spXWG1pt@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, samimseih@gmail.com, bertranddrouvot.pg@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, rahilasyed90@gmail.com
  Subject: Re: Improve LWLock tranche name visibility across backends
  In-Reply-To: <aLHO-jh-spXWG1pt@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox