public inbox for [email protected]  

help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: Kirill Reshke <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected]
Subject: Re: relfilenode statistics
Date: Sun, 9 Nov 2025 08:33:54 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CALdSSPhFaLEWXG9Mn8-tZoS68rE52647a2oZ6jrUNSBtwadD0A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CALdSSPh76=ACN=z68oM44ZMgZsQxTTYVF8qvi1F6TGA5Mn6uiQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Fri, Nov 07, 2025 at 11:28:27AM +0000, Bertrand Drouvot wrote:
> While there are existing rewrite tests, the stats behavior during rewrites
> doesn't have a good coverage. This patch adds some tests to record some stats
> after different rewrite scenarios.
> 
> That way, we'll be able to test that the stats are still the ones we
> expect after rewrites. Note that it generates a new stats_1.out (which is quite
> large), so we may want to move those new tests to "isolation" instead.

Looking at this part of the patch set for now, not looked at the rest
yet.  This new stats_1.out is 2k lines long, introduced for the tests
related to rewrites as an effect of 2PC.  It seems to me that a split 
into a new stats_rewrite would be justified for this case, to reduce
the output duplication.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: relfilenode statistics
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox