From: Nathan Bossart <nathandbossart@gmail.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: vacuumdb: add --dry-run
Date: Tue, 11 Nov 2025 13:46:59 -0600
Message-ID: <aROSszIld_WzC8qh@nathan> (raw)
In-Reply-To: <CADkLM=fo48tbJ75VPDDNgMV3f-QWLCk2TPujGP4ockxVDFRiTQ@mail.gmail.com>
References: <CADkLM=ckHkX7Of5SrK7g0LokPUwJ=kk8JU1GXGF5pZ1eBVr0=Q@mail.gmail.com>
<aRJW2_Yy9ALMkZUa@nathan>
<CADkLM=fo48tbJ75VPDDNgMV3f-QWLCk2TPujGP4ockxVDFRiTQ@mail.gmail.com>
On Mon, Nov 10, 2025 at 05:33:34PM -0500, Corey Huinker wrote:
>> My attempts to test this all got stuck in wait_on_slots(). I haven't
>> looked too closely, but I suspect the issue is that the socket never
>> becomes readable because we don't send a query. If I set free_slot->inUse
>> to false before printing the command, it no longer hangs. We probably want
>> to create a function in parallel_slot.c to mark slots that we don't intend
>> to give a query as idle.
>
> Would that be preferable to skipping the creation of extra connections for
> parallel workers? I can see it both ways. On the one hand we want to give
> as true a reflection of "what would happen with these options", and on the
> other hand one could view the creation of extra workers as "real" vs a dry
> run.
I think what I'm proposing actually does skip creating extra connections.
If we're immediately marking the first connection as idle, each loop
iteration should reuse the same connection.
BTW it might be better to modify run_vacuum_command() to skip running the
command in dry-run mode. That would also take care of the
ONLY_DATABASE_STATS stuff. We should probably do something about the
executeCommand() for --analyze-in-stages, too.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, corey.huinker@gmail.com
Subject: Re: vacuumdb: add --dry-run
In-Reply-To: <aROSszIld_WzC8qh@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox