agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: split tablecmds.c
Date: Mon, 1 Dec 2025 11:25:13 -0600
Message-ID: <aS3PeXHLe7ir_gPc@nathan> (raw)
This file has over 22,000 lines and is too large to be included in GitHub's
code search results [0]. It appears to have been given its current form in
2002 by commit 71dc300. Previously, it was named command.c, which dates
back to the 80s. Is it time to split it into a few different files,
similar to what was done to copy.c in 2020 by commit c532d15?
After briefly skimming through it, some areas that seem like they could
potentially be moved out are partitions, constraints, permission checks,
inheritance, foreign keys, column expressions, table rewriting, attribute
merging, TRUNCATE, and CREATE TABLE. This is far from a concrete proposal,
but I first wanted to gauge interest in $SUBJECT.
[0] https://docs.github.com/en/search-github/github-code-search/about-github-code-search#limitations
--
nathan
view thread (14+ messages) latest in thread
Message-ID: <aS3PeXHLe7ir_gPc@nathan>
Permalink: ../aS3PeXHLe7ir_gPc@nathan/
Also on: postgresql.org/message-id/aS3PeXHLe7ir_gPc@nathan
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com
Subject: Re: split tablecmds.c
In-Reply-To: <aS3PeXHLe7ir_gPc@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox