public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Corey Huinker <[email protected]>
Cc: jian he <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Extended Statistics set/restore/clear functions.
Date: Wed, 26 Nov 2025 15:16:54 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CADkLM=eLYkp=MUTLeu9C5wawON=+DbYyQedOkSH0fwpLS5m=tQ@mail.gmail.com>
References: <CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
<CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
<CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
<CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
<CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<CADkLM=dJzKGDK6aTEaO6NUFmSZ6wTc9Mtkho7KOEaQzjVQy60Q@mail.gmail.com>
<[email protected]>
<CADkLM=eLYkp=MUTLeu9C5wawON=+DbYyQedOkSH0fwpLS5m=tQ@mail.gmail.com>
On Tue, Nov 25, 2025 at 11:50:14PM -0600, Corey Huinker wrote:
> So if a function were previously static to one page, but now had utility
> outside of that file, you would then consider changing the function
> signature to add the consts? I ask because this may become relevant with
> the statatt_* functions being moved in the remaining patches.
That's the kind of analysis that requires a case-by-case lookup. The
input functions were not really that worth bothering to me based on
their logic being very isolated. The refactoring pieces with
attribute stats that you are suggesting in 0003 may be indeed more
relevant if done this way.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (91+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Extended Statistics set/restore/clear functions.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox