public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Greg Burd <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Dave Cramer <[email protected]>
Subject: Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ?barriers
Date: Tue, 16 Dec 2025 15:40:45 -0600
Message-ID: <aUHR3eSjkaBjaUAB@nathan> (raw)
In-Reply-To: <aUGf5oyzguybiUBB@nathan>
References: <aTw8tb_eIpDBYHfW@nathan>
<[email protected]>
<sxhkd5ucchq4vululj6xiwkrd6tsxh53gjiku2knjnqalglumc@hs4vp3b7e7by>
<[email protected]>
<aUB_6ZNFRtjM7FVS@nathan>
<qu3uuja2u3uerwmbhvz6pscdhlhdm3xa3d4nc7lr7vvpowarzl@yn45ne6635ml>
<aUCTH8oP4Wj4r58P@nathan>
<[email protected]>
<[email protected]>
<aUGf5oyzguybiUBB@nathan>
Sorry for the noise.
I discovered that this patch originated in another thread [0], so I spent
some time updating the attributions. Please let me know if there are any
inaccuracies.
On Tue, Dec 16, 2025 at 12:07:34PM -0600, Nathan Bossart wrote:
> Here's what I have staged for commit. I searched around for anything else
> that might be missing, and I only found a couple of small things. First,
> there are some optional AArch64 optimizations (simd.h and popcount) that
> likely need more work, but those can wait for now.
Hm. I think the USE_LLVM_BACKPORT_SECTION_MEMORY_MANAGER thing might need
work, too. We don't have any Windows buildfarm machines with LLVM enabled,
but IIUC it should be possible. Perhaps we can add that to unicorn.
> Also, while the patch
> is targeting Windows 11 (IIUC), there are some notes in the docs that give
> the impression Windows 10 is supported, too [0]. I could easily change it
> to say that AArch64 requires Windows 11, but I don't know what to do with
> the references to specific versions of Visual Studio and the Windows SDK.
Actually, I'm not sure there's anything specific to Windows 11 in this
patch, besides perhaps the choice to set USE_ARMV8_CRC32C unconditionally.
I don't know how likely it is that someone will try to run Postgres on
Windows on an AArch64 machine without CRC extension support, though.
[0] https://postgr.es/m/CAFPTBD-74%2BAEuN9n7caJ0YUnW5A0r-KBX8rYoEJWqFPgLKpzdg%40mail.gmail.com
--
nathan
view thread (42+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ?barriers
In-Reply-To: <aUHR3eSjkaBjaUAB@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox