public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bertrand Drouvot <[email protected]>
To: Jelte Fennema-Nio <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: [email protected]
Subject: Re: Safer hash table initialization macro
Date: Mon, 26 Jan 2026 10:26:11 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<aWdMaa/[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi,

On Mon, Jan 26, 2026 at 11:05:49AM +0100, Jelte Fennema-Nio wrote:
> On Mon Jan 26, 2026 at 9:41 AM CET, Bertrand Drouvot wrote:
> > Also, I can see (I think it's coming from 0004):
> 
> Are you sure you applied the latest one, I had seen that in CI and fixed
> it in v7. Should definitely be fixed now at least.

I can still see it. If I apply from 0001 to 0004 and compile, I see it. It looks
like it's fixed in 0005:

index 54a418a2503..e102adf9f83 100644
--- a/src/backend/utils/cache/typcache.c
+++ b/src/backend/utils/cache/typcache.c
@@ -2409,14 +2409,13 @@ InvalidateCompositeTypeCacheEntry(TypeCacheEntry *typentry)
 static void
 TypeCacheRelCallback(Datum arg, Oid relid)
 {
-       TypeCacheEntry *typentry;
-
        /*
         * RelIdToTypeIdCacheHash and TypeCacheHash should exist, otherwise this
         * callback wouldn't be registered
         */
        if (OidIsValid(relid))
        {
+               TypeCacheEntry *typentry;
                RelIdToTypeIdCacheEntry *relentry;

                /*


but I think that the fix should be in 0004 so that each sub-patch compile without
warnings.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Safer hash table initialization macro
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox