public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Andres Freund <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Aditya Kamath <[email protected]>
Cc: Srirama Kucherlapati <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: AIX support
Date: Fri, 30 Jan 2026 08:24:47 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <vua2n6svb6fac3fmz42ahqxndmgbgor7vpxtemis5evasfpzb3@ogs4ewexkpjm>
References: <SJ4PPFB8177832645802E05CC9DD299E792DB8CA@SJ4PPFB81778326.namprd15.prod.outlook.com>
<[email protected]>
<SJ4PPFB81778326E995FAD5945ECF752FA1DB96A@SJ4PPFB81778326.namprd15.prod.outlook.com>
<SJ4PPFB81778326EC35CBFA16B5449CFA97DB94A@SJ4PPFB81778326.namprd15.prod.outlook.com>
<lx56bdyuajddthcksde62fze7k2oiy3pfczbsuu6ppngcvud7j@cjgb2zem42li>
<SJ4PPFB817783260F14AB4D9AD2CE247DE8DB91A@SJ4PPFB81778326.namprd15.prod.outlook.com>
<LV8PR15MB64883FC333B351ABD169E874D691A@LV8PR15MB6488.namprd15.prod.outlook.com>
<LV8PR15MB64888765A43D229EA5D1CFE6D691A@LV8PR15MB6488.namprd15.prod.outlook.com>
<CA+TgmoatPGOAfL8Wa3uZ1OGXd34EKOzgm6hXSTa1swS=bbQoag@mail.gmail.com>
<vua2n6svb6fac3fmz42ahqxndmgbgor7vpxtemis5evasfpzb3@ogs4ewexkpjm>
On Wed, Jan 28, 2026 at 12:33:01PM -0500, Andres Freund wrote:
> Unfortunately I suspect that'll cause issues with make builds, because there
> the files are generated in a different place (src/backend/activity) and then
> only wait_event_types.h is copied to src/include. So including the files as
> utils/ won't work.
Sorry for the crickets and the delay in replying.
> I'd fix that aspect by doing the same thing in the autoconf build as we do in
> meson, i.e. keep the file in the include dir. We already do that e.g. for
> guc_tables.inc.c, see this src/backend/utils/Makefile stanza:
>
> # These generated headers must be symlinked into src/include/.
> # We use header-stamp to record that we've done this because the symlinks
> # themselves may appear older than fmgr-stamp.
> $(top_builddir)/src/include/utils/header-stamp: fmgr-stamp errcodes.h probes.h guc_tables.inc.c
> cd '$(dir $@)' && for file in fmgroids.h fmgrprotos.h errcodes.h probes.h guc_tables.inc.c; do \
> rm -f $$file && $(LN_S) "../../../$(subdir)/$$file" . ; \
> done
> touch $@
Yeah, using this route would be sensible, removing the trick with the
incorrect include dir. Let me a couple of hours to see if I can sort
out a patch..
Should any of these be backpatched, actually? Based on the lack of
complaints, it does not seem so to me, but if we are targetting a
backpatch of the AIX port, that would be required.
> Alternatively: I'm not a fan of including .c files that are not actually
> working C. You could just make wait_event_funcs_data.c be a complete C file,
> defining waitEventData, that is then built as a standalone file.
FWIW, that does not strike me as an issue. We do some of that already
in src/backend/nodes/ for the switch files. It comes down to simpler
scripts generating the code.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (51+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: AIX support
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox