public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bertrand Drouvot <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Quan Zongliang <[email protected]>
Cc: [email protected]
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: Fri, 30 Jan 2026 11:16:26 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Hi,

On Thu, Jan 29, 2026 at 06:45:12PM +0100, Álvaro Herrera wrote:
> On 2025-Nov-17, Bertrand Drouvot wrote:
> 
> > On Mon, Nov 17, 2025 at 01:12:24PM +0000, Bertrand Drouvot wrote:
> > > The script has been updated and the patch too (finding a new replacement in
> > > gist.c).
> > 
> > Finally, adding GistNSN to the game (as a typedef XLogRecPtr) gives the attached.
> 
> I've pushed this.

Thanks!

I just looked at the cocci script used for that and realized (with more Coccinelle
practice) that it could be simplified. It's done in [1], and lead to a few more
cases discovered and fixed in the attached. I think that, with the attached, we
cover them all.

[1]: https://github.com/bdrouvot/coccinelle_on_pg/blob/main/replace_literal_0_assignement_with_InvalidXLo...

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox