pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nitin Motiani <nitinmotiani@google.com>
Cc: Hannu Krosing <hannuk@google.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
Date: Thu, 12 Feb 2026 16:26:14 -0600
Message-ID: <aY5ThhOKTKIe8S5t@nathan> (raw)
In-Reply-To: <aY5NPLeup3VVucsb@nathan>
References: <nt56moqkh6yoerzw5cml6qu7m4mxu65vqtgdt3nbm5mhpg5hqt@4s5oa3sqhzub>
	<aYTwC8V50rPgw6GE@nathan>
	<t3zu4hyzwqws4puaqd2lhdlw7yp2ckgswuaaizmfi6seto3x4w@5exxg3kazkos>
	<aYT95PGdMvHHzwsP@nathan>
	<aYUL01ZYpDBaZ7qN@nathan>
	<jaqwqwwiy57bhg36jru4mvjznzemrhgobyynpqvyp573m7h3rt@2kpgm5sfkbyy>
	<aYkHiDrBRz2snwyn@nathan>
	<aYzuAz_ITUpd9ZvH@nathan>
	<aY5FaQuLTA0jFinh@alap3.anarazel.de>
	<aY5NPLeup3VVucsb@nathan>

On Thu, Feb 12, 2026 at 03:59:24PM -0600, Nathan Bossart wrote:
> On Thu, Feb 12, 2026 at 04:46:30PM -0500, Andres Freund wrote:
>> I guess you could instead generate a COPY using WITH OIDS. But it's probably
>> not worth having that path, given we already need to support COPY (SELECT ..).
> 
> Ah, I forgot all about that COPY option...
> 
>> as we'd just include the oid column without needing to somehow include it in
>> the attribute list.
>> 
>> [...]
>> 
>> I guess WITH OIDs also would avoid the need for this.
> 
> Will give it a try.

So, in addition to hacking in the OIDS option to the COPY command executed
on the old server, we still need to hack the OID column into the column
list for the dumped COPY command (or omit the column list entirely for
pg_largeobject_metadata).  That seems to result in roughly the same level
of hackery as before.

-- 
nathan





view thread (39+ messages)  latest in thread

Message-ID: <aY5ThhOKTKIe8S5t@nathan>
Permalink:  ../aY5ThhOKTKIe8S5t@nathan/
Also on:    postgresql.org/message-id/aY5ThhOKTKIe8S5t@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, andres@anarazel.de, michael@paquier.xyz, tgl@sss.pgh.pa.us, nitinmotiani@google.com, hannuk@google.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
  In-Reply-To: <aY5ThhOKTKIe8S5t@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox