public inbox for [email protected]  

help / color / mirror / Atom feed

From: Mark Wong <[email protected]>
To: Laurenz Albe <[email protected]>
Cc: David Bidoc <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Guillaume Lelarge <[email protected]>
Cc: [email protected]
Cc: Philip Alger <[email protected]>
Subject: Re: oid2name : add objects file path
Date: Wed, 4 Feb 2026 12:22:40 -0800
Message-ID: <aYOqkDKGAvxieU5Q@ltdrgnflg2> (raw)
In-Reply-To: <[email protected]>
References: <CABour1v2CU1wjjoM86wAFyezJQ3-+ncH43zY1f1uXeVojVN8Ow@mail.gmail.com>
	<[email protected]>
	<CABour1s9hhx508E51=pCJ6W7s0t=ywkBWoseRe9FW-=NNHwZRQ@mail.gmail.com>
	<[email protected]>
	<CABour1vvNTAA1S6zTVTiaz=PWcYFHar7Z6EEP0KRq7EaGAVAdg@mail.gmail.com>
	<[email protected]>
	<CABour1tWqUQU0VtDRbhTy2hbMdOg0u15cb1vD=ZtRT-oAFMz8g@mail.gmail.com>
	<[email protected]>

On Wed, Jan 14, 2026 at 06:24:56AM +0100, Laurenz Albe wrote:
> On Mon, 2025-12-15 at 15:30 +0100, David Bidoc wrote:
> > I attached the rebased and updated patch.
> 
> That patch looks good to me, and I think that is a useful addition.
> 
> If you want to display the path of databases as well, as you tried to
> do in the original patch, I think the way to go would be to write a
> new SQL function pg_database_filepath() similar to pg_relation_filepath().
> That shouldn't be too hard - would you want to try that?
> 
> Other than that, you could try to propose a commit message and
> prepare your patch with
> 
>   git format-patch -v5 -1 -o /mypatches HEAD
> 
> after committing it to your branch.  That would make the committer's
> work easier.

I took a look with Phil Alger and we just have a couple of cosmetic
suggestions.

* There is an extra period (.) added to the change in the documentation.
* We would suggest using "Path" instead of "Filepath" in the column
  name.  While "Filepath" more closely reflects the the function used,
  "Path" reads a little more smoothly, and text in existing
  documentation tends to only reads "path" instead of "file path" when
  referring to paths on the filesystem.

Regards,
Mark
--
Mark Wong <[email protected]>
EDB https://enterprisedb.com

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: oid2name : add objects file path
  In-Reply-To: <aYOqkDKGAvxieU5Q@ltdrgnflg2>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox