public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Mark Wong <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: David Bidoc <[email protected]>
Cc: Guillaume Lelarge <[email protected]>
Cc: [email protected]
Cc: Philip Alger <[email protected]>
Subject: Re: oid2name : add objects file path
Date: Thu, 5 Feb 2026 09:03:29 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <aYOqkDKGAvxieU5Q@ltdrgnflg2>
References: <CABour1v2CU1wjjoM86wAFyezJQ3-+ncH43zY1f1uXeVojVN8Ow@mail.gmail.com>
<[email protected]>
<CABour1s9hhx508E51=pCJ6W7s0t=ywkBWoseRe9FW-=NNHwZRQ@mail.gmail.com>
<[email protected]>
<CABour1vvNTAA1S6zTVTiaz=PWcYFHar7Z6EEP0KRq7EaGAVAdg@mail.gmail.com>
<[email protected]>
<CABour1tWqUQU0VtDRbhTy2hbMdOg0u15cb1vD=ZtRT-oAFMz8g@mail.gmail.com>
<[email protected]>
<aYOqkDKGAvxieU5Q@ltdrgnflg2>
On Wed, Feb 04, 2026 at 12:22:40PM -0800, Mark Wong wrote:
> I took a look with Phil Alger and we just have a couple of cosmetic
> suggestions.
>
> * There is an extra period (.) added to the change in the documentation.
> * We would suggest using "Path" instead of "Filepath" in the column
> name. While "Filepath" more closely reflects the the function used,
> "Path" reads a little more smoothly, and text in existing
> documentation tends to only reads "path" instead of "file path" when
> referring to paths on the filesystem.
Yes, let's just use Path for the whole concept. The two code paths
changed apply to -x, with -t able to filter the data for a single
table. The docs have only one example when combining -x and -t,
meaning that the changes in the patch are OK.
Applied with these changes. Sorry for the delay (I had this patch
marked on my stack of TODO things).
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: oid2name : add objects file path
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox