pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nitin Motiani <nitinmotiani@google.com>
Cc: Hannu Krosing <hannuk@google.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
Date: Thu, 5 Feb 2026 11:40:50 -0600
Message-ID: <aYTWIlvwo4i3UCbP@nathan> (raw)
In-Reply-To: <aYTVAFTPelebVl6W@nathan>
References: <aLqEqVAsT1vzorX-@paquier.xyz>
	<aLsoIeIxlCi-L7C_@nathan>
	<aLuKa8FWd_uMPzSg@paquier.xyz>
	<aL8sgVdZcuqZnvXn@nathan>
	<3yd2ss6n7xywo6pmhd7jjh3bqwgvx35bflzgv3ag4cnzfkik7m@hiyadppqxx6w>
	<sc2uulu7gaajlnis7vqx25hmn6yd74drnlbzvupskx7jwyzejb@3vwodvuurtqb>
	<aYNuhbXkM5h8Zcsu@nathan>
	<aYOnT5EqAqI3ooBO@nathan>
	<qfp7z4c3m6bw53oky33halcdhomiijod6segzrhf757ijjvapr@e5rf4u5wnfmu>
	<aYTVAFTPelebVl6W@nathan>

On Thu, Feb 05, 2026 at 11:36:00AM -0600, Nathan Bossart wrote:
> @@ -1046,7 +1046,7 @@ get_object_address(ObjectType objtype, Node *object,
>  				address.classId = LargeObjectRelationId;
>  				address.objectId = oidparse(object);
>  				address.objectSubId = 0;
> -				if (!LargeObjectExists(address.objectId))
> +				if (!LargeObjectExists(address.objectId) && !IsBinaryUpgrade)
>  				{
>  					if (!missing_ok)
>  						ereport(ERROR,

(Probably better to set missing_ok for only the specific commands we want
to bypass this check, but you get the idea...)

-- 
nathan





view thread (39+ messages)  latest in thread

Message-ID: <aYTWIlvwo4i3UCbP@nathan>
Permalink:  ../aYTWIlvwo4i3UCbP@nathan/
Also on:    postgresql.org/message-id/aYTWIlvwo4i3UCbP@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, andres@anarazel.de, michael@paquier.xyz, tgl@sss.pgh.pa.us, nitinmotiani@google.com, hannuk@google.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
  In-Reply-To: <aYTWIlvwo4i3UCbP@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox