public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: wangpeng <[email protected]>
Cc: [email protected]
Subject: Re: Fix wrong log in pgstat_report_checksum_failures_in_db()
Date: Wed, 11 Feb 2026 20:06:32 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
On Wed, Feb 11, 2026 at 05:22:27PM +0800, wangpeng wrote:
> The function pgstat_report_checksum_failures_in_db(), file
> pgstat_database.c,
> currently emits a log message referring to "conflicts", which seems wrong.
> As the function name suggesting, the log message should refer to "checksum
> failures".
Right, that's strange. It looks like a copy-pasto, but I am not sure
from where.
> - elog(WARNING, "could not report %d conflicts for DB %u",
> + elog(WARNING, "could not report %d checksum failures for DB %u",
> failurecount, dboid);
We may as well use "for database" here. Let's improve it a bit more
while on it, even if it is not translated.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Fix wrong log in pgstat_report_checksum_failures_in_db()
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox