From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: assume availability of "inline" keyword
Date: Thu, 19 Feb 2026 13:54:23 -0600
Message-ID: <aZdqb9df6oqsUq9m@nathan> (raw)
In-Reply-To: <2670103.1771528773@sss.pgh.pa.us>
References: <aZdGbDaV4_yKCMc-@nathan>
<2670103.1771528773@sss.pgh.pa.us>
On Thu, Feb 19, 2026 at 02:19:33PM -0500, Tom Lane wrote:
> All those usages are guarded by
>
> #if defined(__GNUC__) || defined(__INTEL_COMPILER)
>
> so we are only concerned with gcc-alikes, which reduces the risks
> of trouble. However, I have a vague recollection that it is/was
> possible to put gcc in a mode where it only takes __inline__
> not inline. This is likely something you get from -std=c90 or
> thereabouts, which would be irrelevant now. But I'd suggest
> checking it's okay under -std=c11 (not gnu11), just to be sure.
Right. I checked a couple of compilers and none seemed to mind this patch
with -std=c11.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: assume availability of "inline" keyword
In-Reply-To: <aZdqb9df6oqsUq9m@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox