pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Proposal: Save user's original authenticated identity for logging
Date: Fri, 24 Sep 2021 17:37:48 -0400
Message-ID: <aa4e1273-7b29-cdbf-c9b4-e36b44dc78e9@dunslane.net> (raw)
In-Reply-To: <846a497e-e020-76c9-b268-103332872d87@enterprisedb.com>
References: <a4fddbcd2f99c293991b7669bd0da3e5a7d3f93b.camel@vmware.com>
	<YGQk74rdCdb8F9gZ@paquier.xyz>
	<YGUgHMF9zxNvY323@paquier.xyz>
	<d17b919e27474abfa55d97786cb9cfadfe2b59e9.camel@vmware.com>
	<YGaha/euiRjZ820X@paquier.xyz>
	<YGhf4TN6ukOZTUcd@paquier.xyz>
	<ae1143fb-455c-c80f-ed66-78d45bd93303@enterprisedb.com>
	<YUrdnoEc4NPfBZfI@paquier.xyz>
	<2dba8b35-c607-ae30-07d2-610886aff897@enterprisedb.com>
	<814ec049ab4085d9efd3a7a654337ac5008cdaf1.camel@vmware.com>
	<YUxYPBLOLrXWulDh@paquier.xyz>
	<846a497e-e020-76c9-b268-103332872d87@enterprisedb.com>


On 9/23/21 5:20 PM, Peter Eisentraut wrote:
> On 23.09.21 12:34, Michael Paquier wrote:
>> On Wed, Sep 22, 2021 at 03:18:43PM +0000, Jacob Champion wrote:
>>> On Wed, 2021-09-22 at 10:20 +0200, Peter Eisentraut wrote:
>>>> This should be added to each level of a function call that
>>>> represents a
>>>> test.  This ensures that when a test fails, the line number points to
>>>> the top-level location of the test_role() call.  Otherwise it would
>>>> point to the connect_ok() call inside test_role().
>>>
>>> Patch LGTM, sorry about that. Thanks!
>>
>> For the places of the patch, that seems fine then.  Thanks!
>
> committed
>
>> Do we need to care about that in other places?  We have tests in
>> src/bin/ using subroutines that call things from PostgresNode.pm or
>> TestLib.pm, like pg_checksums, pg_ctl or pg_verifybackup, just to name
>> three.
>
> Yeah, at first glance, there is probably more that could be done. 
> Here, I was just looking at a place where it was already and was
> accidentally removed.



It probably wouldn't be a bad thing to have something somewhere
(src/test/perl/README ?) that explains when and why we need to bump
$Test::Builder::Level.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (80+ messages)  latest in thread

Message-ID: <aa4e1273-7b29-cdbf-c9b4-e36b44dc78e9@dunslane.net>
Permalink:  ../aa4e1273-7b29-cdbf-c9b4-e36b44dc78e9@dunslane.net/
Also on:    postgresql.org/message-id/aa4e1273-7b29-cdbf-c9b4-e36b44dc78e9@dunslane.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@dunslane.net, peter.eisentraut@enterprisedb.com, michael@paquier.xyz, pchampion@vmware.com
  Subject: Re: Proposal: Save user's original authenticated identity for logging
  In-Reply-To: <aa4e1273-7b29-cdbf-c9b4-e36b44dc78e9@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox