public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dmitry Koval <[email protected]>
To: Juan José Santamaría Flecha <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: WIN32 pg_import_system_collations
Date: Tue, 25 Jan 2022 10:56:53 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAC+AXB2zm9aBUJHyXU788DgH--aog8iDbwTzpqVOkBFjcNOWPA@mail.gmail.com>
References: <CAC+AXB0WFjJGL1n33bRv8wsnV-3PZD0A7kkjJ2KjPH0dOWqQdg@mail.gmail.com>
<CAC+AXB2Znciv-r9zorGBpTPsTkq1KJY33wrkhsy1QRJ+igUrKg@mail.gmail.com>
<20220119095312.b5ya3fvmmklnopmb@jrouhaud>
<CAC+AXB2zm9aBUJHyXU788DgH--aog8iDbwTzpqVOkBFjcNOWPA@mail.gmail.com>
Hi Juan José,
I a bit tested this feature and have small doubts about block:
+/*
+ * Windows will use hyphens between language and territory, where POSIX
+ * uses an underscore. Simply make it POSIX looking.
+ */
+ hyphen = strchr(localebuf, '-');
+ if (hyphen)
+ *hyphen = '_';
After this block modified collation name is used in function
GetNLSVersionEx(COMPARE_STRING, wide_collcollate, &version)
(see win32_read_locale() -> CollationFromLocale() -> CollationCreate()
call). Is it correct to use (wide_collcollate = "en_NZ") instead of
(wide_collcollate = "en-NZ") in GetNLSVersionEx() function?
1) Documentation [1], [2], quote:
If it is a neutral locale for which the script is significant,
the pattern is <language>-<Script>.
2) Conversation [3], David Rowley, quote:
Then, since GetNLSVersionEx()
wants yet another variant with a - rather than an _, I've just added a
couple of lines to swap the _ for a -.
On my computer (Windows 10 Pro 21H2 19044.1466, MSVC2019 version
16.11.9) work correctly both variants ("en_NZ", "en-NZ").
But David Rowley (MSVC2010 and MSVC2017) replaced "_" to "-"
for the same function. Maybe he had a problem with "_" on MSVC2010 or
MSVC2017?
[1]
https://docs.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getnlsversionex
[2] https://docs.microsoft.com/en-us/windows/win32/intl/locale-names
[3]
https://www.postgresql.org/message-id/flat/CAApHDvq3FXpH268rt-6sD_Uhe7Ekv9RKXHFvpv%3D%3Duh4c9OeHHQ%4...
With best regards,
Dmitry Koval.
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: WIN32 pg_import_system_collations
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox