pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Subject: Re: BUG: Former primary node might stuck when started as a standby
Date: Mon, 2 Mar 2026 16:15:30 +0900
Message-ID: <aaU5EiNHfyMb9Bvu@paquier.xyz> (raw)
In-Reply-To: <c7284102-01fb-4704-8a80-8e65f59fa933@gmail.com>
References: <180bf13e-235d-46a9-9788-7d6cee40bcdc@gmail.com>
	<OS9PR01MB12149E6917AAC1560150B918BF565A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
	<cfd35cfb-3216-42b1-814b-cc658fd0f099@gmail.com>
	<OS9PR01MB12149C0F968A40BA54BD4C16FF561A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
	<e1cf52d2-c344-4dfd-a918-e5f20ff04fa2@gmail.com>
	<OS9PR01MB121498EFA4CBF3003B83C9BCCF56CA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
	<63e55743-669e-4300-a561-7b7ff63723b6@gmail.com>
	<OS9PR01MB12149D4F1A2BC23637688CE4DF56BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
	<045cab6f-4738-417e-b551-01adba44d6c3@gmail.com>
	<c7284102-01fb-4704-8a80-8e65f59fa933@gmail.com>

On Mon, Mar 02, 2026 at 09:00:00AM +0200, Alexander Lakhin wrote:
> As it turned out, v2 patch works as expected, but the test may still fail
> when the build is configured without injection points. Maybe this test (
> and similar one(s)) should be skipped in this case, not sure...

Exactly, I don't see what else we can do here except skip the
sequences of the test that we know may fail if injection points are
not enabled in the build.

Looking at v2, the patch ought to comment the reason *why* these tests
are skipped and *why* an injection point is used.  The reader should
have more details than just a small hint about a set of "random
failures".  I'd suggest to document that once with the first injection
point attached, and have the other blocks hold comments telling to
look at the first block.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../aaU5EiNHfyMb9Bvu@paquier.xyz/2-signature.asc)
  download

view thread (30+ messages)  latest in thread

Message-ID: <aaU5EiNHfyMb9Bvu@paquier.xyz>
Permalink:  ../aaU5EiNHfyMb9Bvu@paquier.xyz/
Also on:    postgresql.org/message-id/aaU5EiNHfyMb9Bvu@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, exclusion@gmail.com, kuroda.hayato@fujitsu.com, aleksander@timescale.com
  Subject: Re: BUG: Former primary node might stuck when started as a standby
  In-Reply-To: <aaU5EiNHfyMb9Bvu@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox